ios/chrome/browser/reading_list/reading_list_pref_names.cc - Issue 2369303002: Reading List create protobuf store

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/reading_list/reading_list_pref_names.cc

Issue 2369303002: Reading List create protobuf store (Closed)

Patch Set: cleaning Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ios/chrome/browser/reading_list/reading_list_pref_names.h"

	6

	7 namespace reading_list {

	8 namespace prefs {

	9

	10 // Boolean which if some reading list entries have never been seen on this
	jif-google 2016/09/27 16:39:03 How about: // Key for a boolean storing whether so How about: // Key for a boolean storing whether some reading list entries have never been seen on this device. Not synced. gambard 2016/09/28 09:19:08 Is it "never seen" or "in unread state"? Is this t Is it "never seen" or "in unread state"? Is this true if the user take a read entry and mark it as unread? Olivier 2016/09/28 11:20:06 unseen means "never opened the view since entry wa Show quoted text On 2016/09/28 09:19:08, gambard wrote: > Is it "never seen" or "in unread state"? Is this true if the user take a read > entry and mark it as unread? unseen means "never opened the view since entry was added". I think the case you describe should not result in the an unseen state.
	11 // device. Not synced.

	12 const char kReadingListHasUnseenEntries[] = "reading_list.has_unseen_entries";

	13

	14 } // namespace prefs

	15 } // namespace reading_list

OLD	NEW