Reading List create protobuf store

ios/chrome/browser/reading_list/reading_list_store.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_
+#define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_
+
+#include "base/memory/weak_ptr.h"
+#include "components/leveldb_proto/proto_database.h"
+#include "ios/chrome/browser/reading_list/reading_list_model_storage.h"
+
+using ReadingListDB =
+    leveldb_proto::ProtoDatabase<reading_list::ReadingListLocal>;
+
+// A ReadingListModelStorage storing data in protobufs.
+class ReadingListStore : public ReadingListModelStorage {
+  using EntryVector = std::vector<reading_list::ReadingListLocal>;

[sdefresne, 2016/10/07 09:44:30]

Move below the "private:" line (as it is not used before that point).

+
+ public:
+  ReadingListStore(std::unique_ptr<ReadingListDB> database,
+                   const base::FilePath& database_dir);
+  virtual ~ReadingListStore();
+
+  // ReadingListModelStorage implementation
+  void SetReadingListModel(ReadingListModelImpl* model) override;
+  void BeginTransaction() override;
+  void CommitTransaction() override;
+  void LoadPersistentLists() override;
+  void SaveEntry(const ReadingListEntry& entry, bool read) override;
+  void RemoveEntry(const ReadingListEntry& entry) override;
+
+ private:
+  void OnDatabaseInit(bool success);
+  void OnDatabaseLoad(bool success, std::unique_ptr<EntryVector> entries);

[sdefresne, 2016/10/07 09:44:30]

Why use a std::unique_ptr<std::vector<reading_list::ReadingListLocal>>? Why not
take a std::vector directly (std::vector<> is movable).

+  void OnDatabaseSave(bool success);
+
+  std::unique_ptr<ReadingListDB> database_;
+  bool database_loaded_;
+  ReadingListModelImpl* model_;
+
+  int pending_transaction_;
+  std::unique_ptr<ReadingListDB::KeyEntryVector> pending_keys_to_save_;
+  std::unique_ptr<std::vector<std::string>> pending_keys_to_remove_;
+
+  base::WeakPtrFactory<ReadingListStore> weak_ptr_factory_;
+};
+
+#endif  // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_