Reading List create protobuf store

ios/chrome/browser/reading_list/reading_list_model_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
 
 #include <utility>
 
 #include "base/memory/singleton.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
+#include "components/leveldb_proto/proto_database.h"
+#include "components/leveldb_proto/proto_database_impl.h"
+#include "components/pref_registry/pref_registry_syncable.h"
 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/reading_list/proto/reading_list.pb.h"
 #include "ios/chrome/browser/reading_list/reading_list_model_impl.h"
-#include "ios/chrome/browser/reading_list/reading_list_model_storage_defaults.h"
+#include "ios/chrome/browser/reading_list/reading_list_pref_names.h"
+#include "ios/chrome/browser/reading_list/reading_list_store.h"
+#include "ios/web/public/web_thread.h"
 
 // static
 ReadingListModel* ReadingListModelFactory::GetForBrowserState(
     ios::ChromeBrowserState* browser_state) {
   return static_cast<ReadingListModelImpl*>(
       GetInstance()->GetServiceForBrowserState(browser_state, true));
 }
 
 // static
 ReadingListModel* ReadingListModelFactory::GetForBrowserStateIfExists(
     ios::ChromeBrowserState* browser_state) {
   return static_cast<ReadingListModelImpl*>(
       GetInstance()->GetServiceForBrowserState(browser_state, false));
 }
 
 // static
 ReadingListModelFactory* ReadingListModelFactory::GetInstance() {
   return base::Singleton<ReadingListModelFactory>::get();
 }
 
 ReadingListModelFactory::ReadingListModelFactory()
     : BrowserStateKeyedServiceFactory(
           "ReadingListModel",
           BrowserStateDependencyManager::GetInstance()) {}
 
 ReadingListModelFactory::~ReadingListModelFactory() {}
 
+void ReadingListModelFactory::RegisterProfilePrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  // Register a not syncable pref.

[sdefresne, 2016/10/07 09:44:30]

nit: this comment has no value in my opinion (if you want to put emphasis on the
fact that the pref is not syncable, pass "NO_REGISTRATION_FLAGS" instead of "0"
for the flag).

+  registry->RegisterBooleanPref(
+      reading_list::prefs::kReadingListHasUnseenEntries, false, 0);
+}
+
 std::unique_ptr<KeyedService> ReadingListModelFactory::BuildServiceInstanceFor(
     web::BrowserState* context) const {
-  std::unique_ptr<ReadingListModelStorage> storage(
-      new ReadingListModelStorageDefaults());
+  scoped_refptr<base::SequencedTaskRunner> background_task_runner =
+      web::WebThread::GetBlockingPool()->GetSequencedTaskRunner(
+          web::WebThread::GetBlockingPool()->GetSequenceToken());
+  base::FilePath database_dir(
+      context->GetStatePath().Append(FILE_PATH_LITERAL("readinglist")));
+
+  std::unique_ptr<ReadingListDB> db = base::MakeUnique<

[sdefresne, 2016/10/07 09:44:30]

nit: auto db = base::MakeUnique<...>(...) is also correct.

+      leveldb_proto::ProtoDatabaseImpl<reading_list::ReadingListLocal>>(
+      background_task_runner);
+
+  std::unique_ptr<ReadingListStore> store =
+      base::MakeUnique<ReadingListStore>(std::move(db), database_dir);
+
+  ios::ChromeBrowserState* chrome_browser_state =
+      ios::ChromeBrowserState::FromBrowserState(context);
   std::unique_ptr<ReadingListModelImpl> reading_list_model(
-      new ReadingListModelImpl(std::move(storage)));
+      new ReadingListModelImpl(std::move(store),

[sdefresne, 2016/10/07 09:44:30]

Use base::MakeUnique<> as the constructor is public.

+                               chrome_browser_state->GetPrefs()));
   return std::move(reading_list_model);

[sdefresne, 2016/10/07 09:44:30]

Do not use "return std::move(...)" with a std::unique_ptr<> as it prevent the
compiler from making some optimisation. Instead just do:

return base::MakeUnique<ReadingListModelImpl>(
    std::move(store), chrome_browser_state->GetPrefs());

 }
 
 web::BrowserState* ReadingListModelFactory::GetBrowserStateToUse(
     web::BrowserState* context) const {
   return GetBrowserStateRedirectedInIncognito(context);
 }