Reading List create protobuf store

ios/chrome/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ios/rules.gni")
 import("//ios/build/config.gni")
 import("//testing/test.gni")
 
 bundle_data("ios_chrome_unittests_bundle_data") {
   testonly = true
@@ skipping 42 matching lines @@
     "browser/net/image_fetcher_unittest.mm",
     "browser/net/metrics_network_client_unittest.mm",
     "browser/net/retryable_url_fetcher_unittest.mm",
     "browser/passwords/credential_manager_js_unittest.mm",
     "browser/passwords/credential_manager_unittest.mm",
     "browser/passwords/password_controller_js_unittest.mm",
     "browser/passwords/password_controller_off_the_record_unittest.mm",
     "browser/passwords/password_controller_unittest.mm",
     "browser/passwords/password_generation_agent_unittest.mm",
     "browser/reading_list/reading_list_entry_unittest.cc",
-    "browser/reading_list/reading_list_model_storage_unittest.mm",
     "browser/reading_list/reading_list_model_unittest.cc",
+    "browser/reading_list/reading_list_store_unittest.cc",
     "browser/reading_list/url_downloader_unittest.cc",
     "browser/signin/chrome_identity_service_observer_bridge_unittest.mm",
     "browser/signin/gaia_auth_fetcher_ios_unittest.mm",
     "browser/snapshots/lru_cache_unittest.mm",
     "browser/snapshots/snapshot_cache_unittest.mm",
     "browser/snapshots/snapshots_util_unittest.mm",
     "browser/ssl/ios_ssl_error_handler_unittest.mm",
     "browser/translate/translate_service_ios_unittest.cc",
     "browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm",
     "browser/ui/alert_coordinator/alert_coordinator_unittest.mm",
@@ skipping 17 matching lines @@
   deps = [
     ":ios_chrome_unittests_bundle_data",
     ":native_content_controller_test_xib",
     "//base",
     "//base/test:test_support",
     "//components/autofill/core/common:common",
     "//components/autofill/ios/browser:browser",
     "//components/bookmarks/test",
     "//components/browsing_data/core",
     "//components/favicon_base",
+    "//components/leveldb_proto:test_support",
     "//components/metrics",
     "//components/metrics:test_support",
     "//components/password_manager/core/browser",
     "//components/password_manager/core/browser:test_support",
     "//components/password_manager/core/common",
     "//components/prefs:test_support",
     "//components/proxy_config:proxy_config",
     "//components/signin/core/browser:test_support",
     "//components/signin/ios/browser:test_support",
     "//components/ssl_config:ssl_config",
     "//components/sync:test_support_sync_driver",
     "//components/syncable_prefs:test_support",
     "//components/update_client",
     "//components/version_info",
     "//ios/chrome/app",
     "//ios/chrome/app/resources:packed_resources",
     "//ios/chrome/browser",
     "//ios/chrome/browser:test_support",
+    "//ios/chrome/browser/reading_list/proto",
     "//ios/chrome/common",
     "//ios/chrome/test",
     "//ios/chrome/test:run_all_unittests",
     "//ios/net",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser:test_support",
     "//ios/testing:ocmock_support",
     "//ios/web",
     "//ios/web:test_support",
     "//net:test_support",
     "//skia",
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/google_toolbox_for_mac",
     "//third_party/ocmock",
     "//ui/base:base",
     "//ui/gfx:test_support",
     "//ui/strings:ui_strings",
   ]
 
+  include_dirs = [ "$root_gen_dir/components/sync/protocol" ]

[sdefresne, 2016/10/06 15:11:24]

You should never have to do that. I think you are missing a dependency (or the
target that generate this should use public_configs instead of configs).

I think ios/chrome/browser/reading_list/proto probably need to also define a
config with this include_dirs, and add it to its public_configs (see my comment
in the other CL).

Even then, I think it strange that you use
"$root_gen_dir/components/sync/protocol", it should be ""$root_gen_dir" and then
you should prefix your paths with "components/sync/protocol".

+
   assert_no_deps = ios_assert_no_deps
 }