Issue 2369293003: [ast] Make FunctionLiteral delegate to its Scope for FunctionKind

Issue 2369293003: [ast] Make FunctionLiteral delegate to its Scope for FunctionKind (Closed)

Created:
4 years, 2 months ago by adamk

Modified:
4 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[ast] Make FunctionLiteral delegate to its Scope for FunctionKind As a side-effect, this lets us remove bit_field_2_ from FunctionLiteral. R=verwaest@chromium.org BUG=v8:5209 Committed: https://crrev.com/841b82a4085a4cb6fc18c4f442f4d3923af630df Cr-Commit-Position: refs/heads/master@{#39799}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -40 lines)			Patch
M	src/ast/ast.h	View	8 chunks	+22 lines, -31 lines	0 comments	Download
M	src/ast/ast.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parsing/parser.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/parsing/parser-base.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/parsing/preparser.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369293003/1

4 years, 2 months ago (2016-09-28 01:18:09 UTC) #8

commit-bot: I haz the power

4 years, 2 months ago (2016-09-28 01:21:09 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/841b82a4085a4cb6fc18c4f442f4d3923af630df
Cr-Commit-Position: refs/heads/master@{#39799}