[DevTools] Improved function preview everywhere

[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org

Committed: https://crrev.com/79415b9b7d748af97fc062e9623e5130f1e38db7
Cr-Commit-Position: refs/heads/master@{#421655}

[kozy, 2016-09-28 02:04:55]

Description was changed from

==========
[DevTools] Added async prefix for async functions

BUG=650160
R=dgozman@chromium.org
==========

to

==========
[DevTools] Added async prefix for async functions

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

[kozy, 2016-09-28 02:04:55]

kozyatinskiy@chromium.org changed reviewers:
+ lushnikov@chromium.org

[kozy, 2016-09-28 02:05:08]

Andrey, please take a look!

[kozy, 2016-09-28 02:23:49]

Description was changed from

==========
[DevTools] Added async prefix for async functions

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

[Dan Ehrenberg, 2016-09-28 07:20:20]

littledan@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-09-28 07:20:21]

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js:1054:
WebInspector.ObjectPropertiesSection._functionPrefixSource =
"^(?:async\\s)?function\\*?\\s";
Does this path have to handle async arrow functions? If so, you may want to edit
this RegExp to highlight that async as a function prefix.

[kozy, 2016-09-28 15:32:46]

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js:1054:
WebInspector.ObjectPropertiesSection._functionPrefixSource =
"^(?:async\\s)?function\\*?\\s";
On 2016/09/28 07:20:21, Dan Ehrenberg wrote:
> Does this path have to handle async arrow functions? If so, you may want to
edit
> this RegExp to highlight that async as a function prefix.

I'll address arrow functions in separate CL.

[lushnikov, 2016-09-28 18:53:19]

lgtm

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js:1054:
WebInspector.ObjectPropertiesSection._functionPrefixSource =
"^(?:async\\s)?function\\*?\\s";
You can avoid double-escaping by using regex directly:

WebInspector.ObjectPropertiesSection._functionPrefix = /..../;

and use WebInspector.ObjectPropertiesSection._functionPrefix.source in :1063

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/objectValue.css
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/objectValue.css:26:
.function-prefix {
.object-value-functoin-prefix?

to be consistent with all the other styles here

[kozy, 2016-09-28 19:42:03]

all done! thanks!

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js:1054:
WebInspector.ObjectPropertiesSection._functionPrefixSource =
"^(?:async\\s)?function\\*?\\s";
On 2016/09/28 18:53:19, lushnikov wrote:
> You can avoid double-escaping by using regex directly:
> 
> WebInspector.ObjectPropertiesSection._functionPrefix = /..../;
> 
> and use WebInspector.ObjectPropertiesSection._functionPrefix.source in :1063

Done.

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/objectValue.css
(right):

https://codereview.chromium.org/2369243004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/objectValue.css:26:
.function-prefix {
On 2016/09/28 18:53:19, lushnikov wrote:
> .object-value-functoin-prefix?
> 
> to be consistent with all the other styles here

Done.

[kozy, 2016-09-28 19:42:07]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-28 19:42:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2369243004/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-28 19:42:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 22:11:46]

Description was changed from

==========
[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

[commit-bot: I haz the power, 2016-09-28 22:11:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-28 22:13:13]

Description was changed from

==========
[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Improved function preview everywhere

async function, function* and regular function is supported:
- in console.log;
- in console.dir;
- in object popover on pause;
- as property of object.

BUG=650160
R=dgozman@chromium.org,lushnikov@chromium.org

Committed: https://crrev.com/79415b9b7d748af97fc062e9623e5130f1e38db7
Cr-Commit-Position: refs/heads/master@{#421655}
==========

[commit-bot: I haz the power, 2016-09-28 22:13:14]

Patchset 4 (id:??) landed as
https://crrev.com/79415b9b7d748af97fc062e9623e5130f1e38db7
Cr-Commit-Position: refs/heads/master@{#421655}