Report network stats in the scroll performance tests

Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency
and packet drop rate. This will allow to evaluate how well the
sender uses available network.

Committed: https://crrev.com/f3b7bdf97930483f31df338942707a3bdf01fb66
Cr-Commit-Position: refs/heads/master@{#421338}

[Sergey Ulanov, 2016-09-27 00:27:20]

sergeyu@chromium.org changed reviewers:
+ isheriff@chromium.org

[Irfan, 2016-09-27 17:52:07]

https://codereview.chromium.org/2369243002/diff/1/remoting/test/protocol_perf...
File remoting/test/protocol_perftest.cc (right):

https://codereview.chromium.org/2369243002/diff/1/remoting/test/protocol_perf...
remoting/test/protocol_perftest.cc:593: <<
client_socket_factory_->GetAverageDelay().InMilliseconds()
It appears a packet is dropped when the buffer overflows in the leaky bucket and
this does not get taken into account.

If you want true impact of the buffer + latency, it seems we should either
measure the packet loss as a result of the buffer drop or take into account the
latency of these dropped packets (MAX) WDYT ?

[Sergey Ulanov, 2016-09-27 20:21:35]

https://codereview.chromium.org/2369243002/diff/1/remoting/test/protocol_perf...
File remoting/test/protocol_perftest.cc (right):

https://codereview.chromium.org/2369243002/diff/1/remoting/test/protocol_perf...
remoting/test/protocol_perftest.cc:593: <<
client_socket_factory_->GetAverageDelay().InMilliseconds()
On 2016/09/27 17:52:07, Irfan wrote:
> It appears a packet is dropped when the buffer overflows in the leaky bucket
and
> this does not get taken into account.
> 
> If you want true impact of the buffer + latency, it seems we should either
> measure the packet loss as a result of the buffer drop or take into account
the
> latency of these dropped packets (MAX) WDYT ?

This is good point. Problem is that the fake network layer doesn't know when
packets are resent, so I don't see how it could measure impact of dropped
packets on total latency.
The goal here is to measure impact of buffer bloat, not the network latency
overall. Updated how this value is reported. Also updated this code to report
packet drop rate.

[Sergey Ulanov, 2016-09-27 20:23:35]

Description was changed from

==========
Report average network latency from in Scroll performance tests

Updated scroll perf tests to report average network latency. This metric
allows to determine how much bufferbloat contributes to total latency
results.
==========

to

==========
Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency 
and packet drop rate. This will allow to evaluate how well the 
sender uses available network.
==========

[Irfan, 2016-09-27 20:52:52]

lgtm

[Sergey Ulanov, 2016-09-27 21:00:44]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:24:53]

Description was changed from

==========
Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency 
and packet drop rate. This will allow to evaluate how well the 
sender uses available network.
==========

to

==========
Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency 
and packet drop rate. This will allow to evaluate how well the 
sender uses available network.
==========

[commit-bot: I haz the power, 2016-09-27 21:24:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 21:29:01]

Description was changed from

==========
Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency 
and packet drop rate. This will allow to evaluate how well the 
sender uses available network.
==========

to

==========
Report network stats in the scroll performance tests

Updated scroll perf tests to report average network buffer latency
and packet drop rate. This will allow to evaluate how well the
sender uses available network.

Committed: https://crrev.com/f3b7bdf97930483f31df338942707a3bdf01fb66
Cr-Commit-Position: refs/heads/master@{#421338}
==========

[commit-bot: I haz the power, 2016-09-27 21:29:02]

Patchset 3 (id:??) landed as
https://crrev.com/f3b7bdf97930483f31df338942707a3bdf01fb66
Cr-Commit-Position: refs/heads/master@{#421338}

[Sergey Ulanov, 2016-09-28 22:17:24]

Patchset #4 (id:60001) has been deleted