Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2369223002: [MR UI] Make paper-items the only selectable elements in cast modes list (Closed)

Created:
4 years, 2 months ago by takumif
Modified:
4 years, 2 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MR UI] Make paper-items the only selectable elements in cast modes list Currently when you are tabbing through the cast mode selection view in the MR dialog, you cannot highlight the casting options, because the "Share your screen" text gets selected instead (which doesn't change its appearance when selected). It's not clear where the selection went, or that you can then highlight the cast modes by pressing up/down arrow keys. This change makes only the cast modes selectable. BUG=614948 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/77463dee8d2a75837f207cc8d8af599a2ac43120 Cr-Commit-Position: refs/heads/master@{#421634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
takumif
Please take a look, thank you!
4 years, 2 months ago (2016-09-26 23:12:05 UTC) #3
imcheng
lgtm
4 years, 2 months ago (2016-09-28 07:29:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369223002/1
4 years, 2 months ago (2016-09-28 20:41:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:45:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:47:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77463dee8d2a75837f207cc8d8af599a2ac43120
Cr-Commit-Position: refs/heads/master@{#421634}

Powered by Google App Engine
This is Rietveld 408576698