DevTools: Dump function location when printing it in console and support inspect() for functions.

Source/devtools/front_end/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 533 matching lines @@
         }
 
         var shortcut = WebInspector.KeyboardShortcut.makeKeyFromEvent(event);
         var handler = this._shortcuts[shortcut];
         if (handler) {
             handler();
             event.preventDefault();
         }
     },
 
+    /**
+     * @param {string} expression
+     * @param {boolean} showResultOnly
+     */
     evaluateUsingTextPrompt: function(expression, showResultOnly)
     {
         this._appendCommand(expression, this.prompt.text, false, showResultOnly);
     },
 
     _enterKeyPressed: function(event)
     {
         if (event.altKey || event.ctrlKey || event.shiftKey)
             return;
 
         event.consume(true);
 
         this.prompt.clearAutoComplete(true);
 
         var str = this.prompt.text;
         if (!str.length)
             return;
         this._appendCommand(str, "", true, false);
     },
 
+    /**
+     * @param {WebInspector.RemoteObject} result
+     * @param {boolean} wasThrown
+     * @param {WebInspector.ConsoleCommand} originatingCommand
+     */
     _printResult: function(result, wasThrown, originatingCommand)
     {
         if (!result)
             return;
-        var message = new WebInspector.ConsoleCommandResult(result, wasThrown, originatingCommand, this._linkifier);
-        WebInspector.console.addMessage(message);
+
+        /**
+         * @param {string=} url
+         * @param {number=} lineNumber
+         * @param {number=} columnNumber
+         */
+        function addMessage(url, lineNumber, columnNumber)
+        {
+            var message = new WebInspector.ConsoleCommandResult(result, wasThrown, originatingCommand, this._linkifier, url, lineNumber, columnNumber);
+            WebInspector.console.addMessage(message);
+        }
+
+        if (result.type !== "function") {
+            addMessage.call(this);
+            return;
+        }
+
+        DebuggerAgent.getFunctionDetails(result.objectId, didGetDetails.bind(this));
+
+        /**
+         * @param {?Protocol.Error} error
+         * @param {DebuggerAgent.FunctionDetails} response
+         */
+        function didGetDetails(error, response)
+        {
+            if (error)
+                console.error(error);

[pfeldman, 2013/08/28 15:46:15]

Return early instead?

+
+            var url;
+            var lineNumber;
+            var columnNumber;
+            var rawLocation = response ? response.location : null;
+            var script = rawLocation ? WebInspector.debuggerModel.scriptForId(rawLocation.scriptId) : null;
+            if (script && script.sourceURL) {
+                url = script.sourceURL;
+                lineNumber = rawLocation.lineNumber + 1;
+                columnNumber = rawLocation.columnNumber + 1;

[pfeldman, 2013/08/28 15:46:15]

Lets remove the mess.

+            }
+            addMessage.call(this, url, lineNumber, columnNumber);
+        }
     },
 
+    /**
+     * @param {string} text
+     * @param {string} newPromptText
+     * @param {boolean} useCommandLineAPI
+     * @param {boolean} showResultOnly
+     */
     _appendCommand: function(text, newPromptText, useCommandLineAPI, showResultOnly)
     {
         if (!showResultOnly) {
             var commandMessage = new WebInspector.ConsoleCommand(text);
             WebInspector.console.addMessage(commandMessage);
         }
         this.prompt.text = newPromptText;
 
-        function printResult(result, wasThrown)
+        /**
+         * @param {WebInspector.RemoteObject} result
+         * @param {boolean} wasThrown
+         * @param {RuntimeAgent.RemoteObject=} valueResult
+         */
+        function printResult(result, wasThrown, valueResult)
         {
             if (!result)
                 return;
 
             if (!showResultOnly) {
                 this.prompt.pushHistoryItem(text);
                 WebInspector.settings.consoleHistory.set(this.prompt.historyData.slice(-30));
             }
-            
+
             this._printResult(result, wasThrown, commandMessage);
         }
         WebInspector.runtimeModel.evaluate(text, "console", useCommandLineAPI, false, false, true, printResult.bind(this));
 
         WebInspector.userMetrics.ConsoleEvaluated.record();
     },
 
     elementsToRestoreScrollPositionsFor: function()
     {
         return [this.messagesElement];
@@ skipping 399 matching lines @@
     },
 
     clearHighlight: function()
     {
         var highlightedMessage = this._formattedCommand;
         delete this._formattedCommand;
         this._formatCommand();
         this._element.replaceChild(this._formattedCommand, highlightedMessage);
     },
 
+    /**
+     * @param {RegExp} regexObject
+     */
     highlightSearchResults: function(regexObject)
     {
         regexObject.lastIndex = 0;
         var match = regexObject.exec(this.text);
         var matchRanges = [];
         while (match) {
             matchRanges.push({ offset: match.index, length: match[0].length });
             match = regexObject.exec(this.text);
         }
         WebInspector.highlightSearchResults(this._formattedCommand, matchRanges);
         this._element.scrollIntoViewIfNeeded();
     },
 
+    /**
+     * @param {RegExp} regexObject
+     */
     matchesRegex: function(regexObject)
     {
         regexObject.lastIndex = 0;
         return regexObject.test(this.text);
     },
 
     toMessageElement: function()
     {
         if (!this._element) {
             this._element = document.createElement("div");
@@ skipping 12 matching lines @@
         this._formattedCommand.className = "console-message-text source-code";
         this._formattedCommand.textContent = this.text;
     },
 
     __proto__: WebInspector.ConsoleMessage.prototype
 }
 
 /**
  * @extends {WebInspector.ConsoleMessageImpl}
  * @constructor
- * @param {boolean} result
+ * @param {WebInspector.RemoteObject} result
  * @param {boolean} wasThrown
  * @param {WebInspector.ConsoleCommand} originatingCommand
  * @param {WebInspector.Linkifier} linkifier
+ * @param {string=} url
+ * @param {number=} lineNumber
+ * @param {number=} columnNumber
  */
-WebInspector.ConsoleCommandResult = function(result, wasThrown, originatingCommand, linkifier)
+WebInspector.ConsoleCommandResult = function(result, wasThrown, originatingCommand, linkifier, url, lineNumber, columnNumber)
 {
     var level = (wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log);
     this.originatingCommand = originatingCommand;
-    WebInspector.ConsoleMessageImpl.call(this, WebInspector.ConsoleMessage.MessageSource.JS, level, "", linkifier, WebInspector.ConsoleMessage.MessageType.Result, undefined, undefined, undefined, undefined, [result]);
+    WebInspector.ConsoleMessageImpl.call(this, WebInspector.ConsoleMessage.MessageSource.JS, level, "", linkifier, WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, [result]);
 }
 
 WebInspector.ConsoleCommandResult.prototype = {
     /**
      * @override
      * @param {WebInspector.RemoteObject} array
      * @return {boolean}
      */
     useArrayPreviewInFormatter: function(array)
     {
@@ skipping 77 matching lines @@
 
 /**
  * @type {?WebInspector.ConsoleView}
  */
 WebInspector.consoleView = null;
 
 WebInspector.ConsoleMessage.create = function(source, level, message, type, url, line, column, repeatCount, parameters, stackTrace, requestId, isOutdated)
 {
     return new WebInspector.ConsoleMessageImpl(source, level, message, WebInspector.consoleView._linkifier, type, url, line, column, repeatCount, parameters, stackTrace, requestId, isOutdated);
 }