Issue 23692002: DevTools: Dump function location when printing it in console and support inspect() for functions.

Issue 23692002: DevTools: Dump function location when printing it in console and support inspect() for functions. (Closed)

Created:
7 years, 3 months ago by vsevik

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Dump function location when printing it in console and support inspect() for functions. BUG=279442 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156923

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments addressed #

Patch Set 3 : Fixed test #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -11 lines)			Patch
M	LayoutTests/inspector/console/console-format-expected.txt	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/CPUProfileView.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ConsoleView.js	View	1	7 chunks	+77 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/ScriptsPanel.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/inspector.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/23692002/diff/1/Source/devtools/front_end/ConsoleView.js File Source/devtools/front_end/ConsoleView.js (right): https://codereview.chromium.org/23692002/diff/1/Source/devtools/front_end/ConsoleView.js#newcode613 Source/devtools/front_end/ConsoleView.js:613: console.error(error); Return early instead? https://codereview.chromium.org/23692002/diff/1/Source/devtools/front_end/ConsoleView.js#newcode623 Source/devtools/front_end/ConsoleView.js:623: columnNumber = ...

7 years, 3 months ago (2013-08-28 15:46:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23692002/6001

7 years, 3 months ago (2013-08-29 10:21:22 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3510

7 years, 3 months ago (2013-08-29 11:52:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23692002/22001

7 years, 3 months ago (2013-08-29 13:08:55 UTC) #5

Message was sent while issue was closed.

Change committed as 156923

Expand Messages | Collapse Messages