Issue 2369143005: Update vm/BUILD.gn to account for stricter GN warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2369143005: Update vm/BUILD.gn to account for stricter GN warnings. (Closed)

Created:
4 years, 2 months ago by Chinmay

Modified:
4 years, 2 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/vm/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Chinmay

We are updating the GN revision and it seems to have gotten stricter about clearing ...

4 years, 2 months ago (2016-09-27 23:13:03 UTC) #2

Chinmay

4 years, 2 months ago (2016-09-27 23:16:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b29788329baab1183f6e430bc2cf3c4169b20621 (presubmit successful).