Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2369133002: [modules] Add tests for empty imports. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add tests for empty imports. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/0614eb54715808c63484e4b033fc8c1e3eac3834 Cr-Commit-Position: refs/heads/master@{#39739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
A + test/mjsunit/modules-empty-import1.js View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/modules-empty-import2.js View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/modules-empty-import3.js View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/modules-empty-import4.js View 1 chunk +11 lines, -0 lines 0 comments Download
A + test/mjsunit/modules-skip-empty-import.js View 1 chunk +2 lines, -4 lines 0 comments Download
A + test/mjsunit/modules-skip-empty-import-aux.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
neis
4 years, 2 months ago (2016-09-26 18:16:53 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-09-26 18:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369133002/1
4 years, 2 months ago (2016-09-26 18:23:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:55:56 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:56:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0614eb54715808c63484e4b033fc8c1e3eac3834
Cr-Commit-Position: refs/heads/master@{#39739}

Powered by Google App Engine
This is Rietveld 408576698