Issue 23691071: OS(ANDROID) should not imply OS(LINUX)

Issue 23691071: OS(ANDROID) should not imply OS(LINUX) (Closed)

Created:
7 years, 3 months ago by atreat

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, loislo+blink_chromium.org, jsbell+bindings_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

OS(ANDROID) should not imply OS(LINUX) Change the config.h of blink to match the behavior in chromium's build_config.h BUG=286645 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158858

Patch Set 1 #

Patch Set 2 : Rebased on trunk #

Patch Set 3 : Refactor OS macros to have exclusive priority order #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -22 lines)			Patch
M	Source/config.h	View	1 2	1 chunk	+5 lines, -15 lines	0 comments	Download
M	Source/web/PopupListBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/linux/WebFontRendering.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Assertions.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

atreat

This patch tries to align the definitions of OS(ANDROID) between chromium and blink configuration files.

7 years, 3 months ago (2013-09-17 20:35:45 UTC) #1

abarth-chromium

LGTM assuming this matches what Chromium is doing.

7 years, 3 months ago (2013-09-17 20:41:59 UTC) #2

lgombos

On 2013/09/17 20:41:59, abarth wrote: > LGTM assuming this matches what Chromium is doing. Perhaps ...

7 years, 3 months ago (2013-09-17 21:16:40 UTC) #3

atreat

I've modified this patch according to Laszlo's suggestion and rebased so that it applies upon ...

7 years, 2 months ago (2013-10-02 21:31:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/23691071/8001

7 years, 2 months ago (2013-10-03 15:35:23 UTC) #6

Message was sent while issue was closed.

Change committed as 158858

Expand Messages | Collapse Messages