chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h - Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

index 1d16f970de6edc5e1d762a64827bc1ec69fe0e91..5d0286177bcbc3e375f0a5d05749da44f12ff717 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

@@ -23,7 +23,7 @@ class WebrtcLoggingPrivateSetMetaDataFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Must be called on UI thread.

- void SetMetaDataCallback(bool success);

+ void SetMetaDataCallback(bool success, const std::string& error_message);

};

class WebrtcLoggingPrivateStartFunction : public AsyncExtensionFunction {

@@ -39,7 +39,7 @@ class WebrtcLoggingPrivateStartFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Must be called on UI thread.

- void StartCallback(bool success);

+ void StartCallback(bool success, const std::string& error_message);

};

class WebrtcLoggingPrivateSetUploadOnRenderCloseFunction

@@ -69,7 +69,7 @@ class WebrtcLoggingPrivateStopFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Must be called on UI thread.

- void StopCallback(bool success);

+ void StopCallback(bool success, const std::string& error_message);

};

class WebrtcLoggingPrivateUploadFunction : public AsyncExtensionFunction {

@@ -85,7 +85,8 @@ class WebrtcLoggingPrivateUploadFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Must be called on UI thread.

- void UploadCallback(bool success, std::string report_id);

+ void UploadCallback(bool success, const std::string& report_id,

+ const std::string& error_message);

};

class WebrtcLoggingPrivateDiscardFunction : public AsyncExtensionFunction {

@@ -101,7 +102,7 @@ class WebrtcLoggingPrivateDiscardFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Must be called on UI thread.

- void DiscardCallback(bool success);

+ void DiscardCallback(bool success, const std::string& error_message);

};

} // namespace extensions