Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7371)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/media/webrtc_logging_messages.h

Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First patch ready for review. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/api/_permission_features.json ('K') | « chrome/common/extensions/api/webrtc_logging_private.idl ('k') | chrome/renderer/media/chrome_webrtc_log_message_delegate.h » ('j') | content/renderer/media/media_stream_dependency_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/media/webrtc_logging_messages.h
diff --git a/chrome/common/media/webrtc_logging_messages.h b/chrome/common/media/webrtc_logging_messages.h
index cceea8f800f93b8af4b7a549fcb3d93b755b7e52..af2ada3e2ad6c1912b8946a9cb54707283785be5 100644
--- a/chrome/common/media/webrtc_logging_messages.h
+++ b/chrome/common/media/webrtc_logging_messages.h
@@ -12,17 +12,15 @@
// Messages sent from the renderer to the browser.
-// Request to open a log.
-IPC_MESSAGE_CONTROL2(WebRtcLoggingMsg_OpenLog,
- std::string /* app_session_id */,
- std::string /* app_url */)
+// Notification that the log has been closed.
+IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_LoggingStopped)
// Messages sent from the browser to the renderer.
-// Notification that a log could not be opened.
-IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_OpenLogFailed)
-
-// Notification that a log has been opened.
-IPC_MESSAGE_CONTROL2(WebRtcLoggingMsg_LogOpened,
+// Tells the renderer to open the log.
+IPC_MESSAGE_CONTROL2(WebRtcLoggingMsg_StartLogging,
base::SharedMemoryHandle /* handle */,
uint32 /* length */)
+
+// Tells the renderer to close the log.
+IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_StopLogging)
« chrome/common/extensions/api/_permission_features.json ('K') | « chrome/common/extensions/api/webrtc_logging_private.idl ('k') | chrome/renderer/media/chrome_webrtc_log_message_delegate.h » ('j') | content/renderer/media/media_stream_dependency_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698