Chromium Code Reviews| Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h |
| diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h |
| index 1d16f970de6edc5e1d762a64827bc1ec69fe0e91..a94ece17fb220d7c8e3e1a8e5d66e493b2e21b38 100644 |
| --- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h |
| +++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h |
| @@ -23,7 +23,7 @@ class WebrtcLoggingPrivateSetMetaDataFunction : public AsyncExtensionFunction { |
| virtual bool RunImpl() OVERRIDE; |
| // Must be called on UI thread. |
| - void SetMetaDataCallback(bool success); |
| + void SetMetaDataCallback(bool success, std::string error_message); |
|
Finnur
2013/09/27 14:10:06
nit: const std::string& ?
Same below.
Henrik Grunell
2013/10/02 12:47:18
Absolutely, done.
|
| }; |
| class WebrtcLoggingPrivateStartFunction : public AsyncExtensionFunction { |
| @@ -39,7 +39,7 @@ class WebrtcLoggingPrivateStartFunction : public AsyncExtensionFunction { |
| virtual bool RunImpl() OVERRIDE; |
| // Must be called on UI thread. |
| - void StartCallback(bool success); |
| + void StartCallback(bool success, std::string error_message); |
| }; |
| class WebrtcLoggingPrivateSetUploadOnRenderCloseFunction |
| @@ -69,7 +69,7 @@ class WebrtcLoggingPrivateStopFunction : public AsyncExtensionFunction { |
| virtual bool RunImpl() OVERRIDE; |
| // Must be called on UI thread. |
| - void StopCallback(bool success); |
| + void StopCallback(bool success, std::string error_message); |
| }; |
| class WebrtcLoggingPrivateUploadFunction : public AsyncExtensionFunction { |
| @@ -85,7 +85,8 @@ class WebrtcLoggingPrivateUploadFunction : public AsyncExtensionFunction { |
| virtual bool RunImpl() OVERRIDE; |
| // Must be called on UI thread. |
| - void UploadCallback(bool success, std::string report_id); |
| + void UploadCallback(bool success, std::string report_id, |
| + std::string error_message); |
| }; |
| class WebrtcLoggingPrivateDiscardFunction : public AsyncExtensionFunction { |
| @@ -101,7 +102,7 @@ class WebrtcLoggingPrivateDiscardFunction : public AsyncExtensionFunction { |
| virtual bool RunImpl() OVERRIDE; |
| // Must be called on UI thread. |
| - void DiscardCallback(bool success); |
| + void DiscardCallback(bool success, std::string error_message); |
| }; |
| } // namespace extensions |