Issue 23691040: Ensure that popup windows created by the content layer in desktop AURA don't grab activation when t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23691040: Ensure that popup windows created by the content layer in desktop AURA don't grab activation when t… (Closed)

Created:
7 years, 3 months ago by ananta

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Ensure that popup windows created by the content layer in desktop AURA don't grab activation when the user clicks on them. This basically translates to setting the can_activate property in the widget init params to false. Fixes bug https://code.google.com/p/chromium/issues/detail?id=282628 BUG=282628 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221279

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ananta

7 years, 3 months ago (2013-09-04 22:07:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r221279 (presubmit successful).