Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: content/renderer/media/media_stream_dependency_factory.h

Issue 23691038: Switch LiveAudio to source provider solution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased and fixed some unittests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_dependency_factory.h
diff --git a/content/renderer/media/media_stream_dependency_factory.h b/content/renderer/media/media_stream_dependency_factory.h
index c89f274a6c099d41d67a4b1a83acfbfd81892881..1619bda80281e3947aacf2f4e58bbb8894b7ba20 100644
--- a/content/renderer/media/media_stream_dependency_factory.h
+++ b/content/renderer/media/media_stream_dependency_factory.h
@@ -44,6 +44,7 @@ class IpcNetworkManager;
class IpcPacketSocketFactory;
class RTCMediaConstraints;
class VideoCaptureImplManager;
+class WebAudioCapturerSource;
class WebRtcAudioCapturer;
class WebRtcAudioDeviceImpl;
class WebRtcLoggingHandlerImpl;
@@ -164,16 +165,16 @@ class CONTENT_EXPORT MediaStreamDependencyFactory
// WebRtcAudioCapturer.
// The |constraints| will be modified to include the default, mandatory
// WebAudio constraints.
- virtual scoped_refptr<WebRtcAudioCapturer> CreateWebAudioSource(
- WebKit::WebMediaStreamSource* source,
- RTCMediaConstraints* constraints);
+ virtual scoped_refptr<WebAudioCapturerSource> CreateWebAudioSource(
+ WebKit::WebMediaStreamSource* source, RTCMediaConstraints* constraints);
// Asks the PeerConnection factory to create a Local AudioTrack object.
virtual scoped_refptr<webrtc::AudioTrackInterface>
CreateLocalAudioTrack(
const std::string& id,
const scoped_refptr<WebRtcAudioCapturer>& capturer,
- webrtc::AudioSourceInterface* source,
+ WebAudioCapturerSource* webaudio_source,
tommi (sloooow) - chröme 2013/09/06 11:20:30 Please add documentation for this parameter. It's
+ webrtc::AudioSourceInterface* track_source,
tommi (sloooow) - chröme 2013/09/06 11:20:30 nit: just keep the name as |source|
no longer working on chromium 2013/09/10 12:43:15 Done.
const webrtc::MediaConstraintsInterface* constraints);
// Asks the PeerConnection factory to create a Local VideoTrack object.

Powered by Google App Engine
This is Rietveld 408576698