Source/core/html/HTMLMediaElement.cpp - Issue 23691033: Fix threading races on WebAudioSourceProviderImpl::provideInput

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 23691033: Fix threading races on WebAudioSourceProviderImpl::provideInput (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 719d388704c908c3a68a8c9e1e54cd295fd7447a..f2207e6ff96235a08162b46c3ec2da9be2998992 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -343,6 +343,8 @@ HTMLMediaElement::~HTMLMediaElement()

// See http://crbug.com/233654 for more details.

m_completelyLoaded = true;

m_player.clear();

+ if (audioSourceProvider())

DaleCurtis 2013/09/04 22:33:09 Both of these need protection via #if ENABLE(WEB_A

+ audioSourceProvider()->setClient(0);

}

void HTMLMediaElement::didMoveToNewDocument(Document* oldDocument)

@@ -3454,6 +3456,8 @@ void HTMLMediaElement::clearMediaPlayer(int flags)

closeMediaSource();

m_player.clear();

+ if (audioSourceProvider())

+ audioSourceProvider()->setClient(0);

stopPeriodicTimers();

m_loadTimer.stop();

« no previous file with comments | « no previous file | no next file » | no next file with comments »