Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5271)

Unified Diff: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc

Issue 2369103002: [Sync] Move conflict resolution test code to FakeModelTypeService. (Closed)
Patch Set: Address comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/api/fake_model_type_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
index 0e46e7049f6f60c9c38c7b6bfba9ee781c3de781..b9df9538c0d7a1787998a90d1c71916cec9d5e10 100644
--- a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
@@ -17,6 +17,7 @@
using browser_sync::ChromeSyncClient;
using browser_sync::ProfileSyncComponentsFactoryImpl;
+using syncer_v2::ConflictResolution;
using syncer_v2::FakeModelTypeService;
using syncer_v2::ModelTypeService;
using syncer_v2::SharedModelTypeProcessor;
@@ -24,7 +25,7 @@ using syncer_v2::SharedModelTypeProcessor;
const char kKey1[] = "key1";
const char kValue1[] = "value1";
const char kValue2[] = "value2";
-const char kResolutionValue[] = "RESOLVED";
+const char kValue3[] = "value3";
// A ChromeSyncClient that provides a ModelTypeService for PREFERENCES.
class TestSyncClient : public ChromeSyncClient {
@@ -69,13 +70,6 @@ class TestModelTypeService : public FakeModelTypeService {
db().CreateMetadataBatch());
}
- syncer_v2::ConflictResolution ResolveConflict(
- const syncer_v2::EntityData& local_data,
- const syncer_v2::EntityData& remote_data) const override {
- return syncer_v2::ConflictResolution::UseNew(
- GenerateEntityData(local_data.non_unique_name, kResolutionValue));
- }
-
void AddObserver(Observer* observer) { observers_.insert(observer); }
void RemoveObserver(Observer* observer) { observers_.erase(observer); }
@@ -293,6 +287,10 @@ IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, ConflictResolution) {
ASSERT_TRUE(SetupSync());
TestModelTypeService* model1 = GetModelTypeService(0);
TestModelTypeService* model2 = GetModelTypeService(1);
+ model1->SetConflictResolution(ConflictResolution::UseNew(
+ FakeModelTypeService::GenerateEntityData(kKey1, kValue3)));
+ model2->SetConflictResolution(ConflictResolution::UseNew(
+ FakeModelTypeService::GenerateEntityData(kKey1, kValue3)));
// Write conflicting entities.
model1->WriteItem(kKey1, kValue1);
@@ -300,6 +298,6 @@ IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, ConflictResolution) {
// Wait for them to be resolved to kResolutionValue by the custom conflict
// resolution logic in TestModelTypeService.
- ASSERT_TRUE(DataChecker(model1, kKey1, kResolutionValue).Wait());
- ASSERT_TRUE(DataChecker(model2, kKey1, kResolutionValue).Wait());
+ ASSERT_TRUE(DataChecker(model1, kKey1, kValue3).Wait());
+ ASSERT_TRUE(DataChecker(model2, kKey1, kValue3).Wait());
}
« no previous file with comments | « no previous file | components/sync/api/fake_model_type_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698