Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: components/sync/core/shared_model_type_processor_unittest.cc

Issue 2369103002: [Sync] Move conflict resolution test code to FakeModelTypeService. (Closed)
Patch Set: Self-review. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/core/shared_model_type_processor_unittest.cc
diff --git a/components/sync/core/shared_model_type_processor_unittest.cc b/components/sync/core/shared_model_type_processor_unittest.cc
index 8108cb08126a58c3013622142c44b7449204b877..61d57113604c2e37eb9f1d13aa14849f5cf78717 100644
--- a/components/sync/core/shared_model_type_processor_unittest.cc
+++ b/components/sync/core/shared_model_type_processor_unittest.cc
@@ -195,12 +195,6 @@ class SharedModelTypeProcessorTest : public ::testing::Test,
return type_processor()->entities_.size();
}
- // Store a resolution for the next call to ResolveConflict. Note that if this
- // is a USE_NEW resolution, the data will only exist for one resolve call.
- void SetConflictResolution(ConflictResolution resolution) {
- conflict_resolution_.reset(new ConflictResolution(std::move(resolution)));
- }
-
// Sets the error type that OnReadyToConnect (our StartCallback) expects to
// receive.
void ExpectStartError(syncer::SyncError::ErrorType error_type) {
@@ -260,15 +254,6 @@ class SharedModelTypeProcessorTest : public ::testing::Test,
base::Unretained(this), callback));
}
- ConflictResolution ResolveConflict(
- const EntityData& local_data,
- const EntityData& remote_data) const override {
- DCHECK(conflict_resolution_);
- return std::move(*conflict_resolution_);
- }
-
- std::unique_ptr<ConflictResolution> conflict_resolution_;
-
// This sets ThreadTaskRunnerHandle on the current thread, which the type
// processor will pick up as the sync task runner.
base::MessageLoop sync_loop_;

Powered by Google App Engine
This is Rietveld 408576698