[Android WebView] Treat zero values in viewport arguments specially

Source/web/WebViewImpl.cpp

Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index bcfa7c3158c8ce8494405d14230a87912344b255..8e845e16bb71b6b95af37f0722a552d669eee8be 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3017,6 +3017,10 @@ void WebViewImpl::updatePageDefinedPageScaleConstraints(const ViewportArguments&
     ViewportArguments adjustedArguments = arguments;
     if (settingsImpl()->viewportMetaLayoutSizeQuirk() && adjustedArguments.type == ViewportArguments::ViewportMeta)
         adjustedArguments.type = ViewportArguments::ViewportMetaLayoutSizeQuirk;
+    if (page()->settings().viewportMetaZeroValuesQuirk() && adjustedArguments.type == ViewportArguments::ViewportMeta) {

[rune, 2013/09/02 20:09:06]

Looking at the if-test two lines further up, this if triggers if
viewportMetaLayoutSizeQuirk is off and viewportMetaZeroValuesQuirk is on. That
doesn't make sense if they could have been one quirk like in the previous patch
set?

[mnaganov (inactive), 2013/09/03 09:07:27]

I was proposing to merge those two quirks because I was only thinking in terms
of ViewportArguments::resolve implementation and didn't see other way around.
But as we have moved the processing of the "zero values" quirk into the parsing
stage, they actually can be independent. As I've understood from the discussions
with Adam Barth and Eric Seidel, they would prefer to deal with small
independent quirks than a big complex one.

+        if (adjustedArguments.width == ViewportArguments::ValueDeviceWidth && !static_cast<int>(adjustedArguments.zoom))
+            adjustedArguments.zoom = 1.0;

[rune, 2013/09/02 20:09:06]

If I understand this correctly, this could also have been done at parse-time
right after processArguments() in Document::processViewport().

[mnaganov (inactive), 2013/09/03 09:07:27]

Thanks for the suggestion! Moved.

+    }
     m_pageScaleConstraintsSet.updatePageDefinedConstraints(adjustedArguments, m_size, page()->settings().layoutFallbackWidth());
 
     if (settingsImpl()->supportDeprecatedTargetDensityDPI())