chrome/common/extensions/features/simple_feature.cc - Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature.cc

Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/features/complex_feature_unittest.cc ('k') | chrome/common/extensions/features/simple_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/simple_feature.cc

diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc

index e8ee3d5fcb32bf8824ce12988527fdfc3a4f7262..2f47701027b6132ec67df044bd7a94093bad53c7 100644

--- a/chrome/common/extensions/features/simple_feature.cc

+++ b/chrome/common/extensions/features/simple_feature.cc

@@ -26,7 +26,7 @@ struct Mappings {

Mappings() {

extension_types["extension"] = Manifest::TYPE_EXTENSION;

extension_types["theme"] = Manifest::TYPE_THEME;

- extension_types["packaged_app"] = Manifest::TYPE_LEGACY_PACKAGED_APP;

+ extension_types["legacy_packaged_app"] = Manifest::TYPE_LEGACY_PACKAGED_APP;

extension_types["hosted_app"] = Manifest::TYPE_HOSTED_APP;

extension_types["platform_app"] = Manifest::TYPE_PLATFORM_APP;

extension_types["shared_module"] = Manifest::TYPE_SHARED_MODULE;

@@ -161,9 +161,9 @@ std::string GetDisplayTypeName(Manifest::Type type) {

case Manifest::TYPE_HOSTED_APP:

return "hosted app";

case Manifest::TYPE_LEGACY_PACKAGED_APP:

- return "legacy packaged app";

+ return "legacy legacy packaged app";

case Manifest::TYPE_PLATFORM_APP:

- return "packaged app";

+ return "legacy packaged app";

asargent_no_longer_on_chrome 2013/08/29 23:45:59 wow, this was totally wrong before, huh?

not at google - send to devlin 2013/08/29 23:48:12 search-replace fail on my part :)

case Manifest::TYPE_THEME:

return "theme";

case Manifest::TYPE_USER_SCRIPT: