Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2369083003:
Deprecate PageLoadMetricsClientsReload (Closed)
|
Created:
4 years, 2 months ago by Takashi Toyoshima Modified:
4 years, 2 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeprecate PageLoadMetricsClientsReload
Now LoadType.Reload metrics are available on the stable channel,
and it's fine to mark Clients.Reload as obsolete.
BUG=625749
Committed: https://crrev.com/868a54281467eca55f25a6cb55e81f438a999758
Cr-Commit-Position: refs/heads/master@{#421423}
Patch Set 1 #
Messages
Total messages: 14 (7 generated)
Description was changed from ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 ========== to ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 ==========
toyoshim@chromium.org changed reviewers: + isherman@chromium.org
As I promised in a code review months ago, I will deprecate these metrics now.
LGTM, thanks!
The CQ bit was checked by isherman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 ========== to ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 ========== to ========== Deprecate PageLoadMetricsClientsReload Now LoadType.Reload metrics are available on the stable channel, and it's fine to mark Clients.Reload as obsolete. BUG=625749 Committed: https://crrev.com/868a54281467eca55f25a6cb55e81f438a999758 Cr-Commit-Position: refs/heads/master@{#421423} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/868a54281467eca55f25a6cb55e81f438a999758 Cr-Commit-Position: refs/heads/master@{#421423} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
