Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/sync/driver/non_blocking_data_type_controller.cc

Issue 2369063003: [Sync] Add an error integration test for USS. (Closed)
Patch Set: Fix a DCHECK in DTMI. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/sync/driver/data_type_manager_impl.cc ('K') | « components/sync/driver/data_type_manager_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/non_blocking_data_type_controller.cc
diff --git a/components/sync/driver/non_blocking_data_type_controller.cc b/components/sync/driver/non_blocking_data_type_controller.cc
index c414de2e7f9126c8522b840731a92545aab71fe4..a01905d7af7ca012dead37a7230d33d9192bc539 100644
--- a/components/sync/driver/non_blocking_data_type_controller.cc
+++ b/components/sync/driver/non_blocking_data_type_controller.cc
@@ -217,10 +217,7 @@ NonBlockingDataTypeController::CreateErrorHandler() {
void NonBlockingDataTypeController::ReportLoadModelError(
const syncer::SyncError& error) {
DCHECK(CalledOnValidThread());
- // Report the error only if the model is starting.
- if (state_ == MODEL_STARTING) {
skym 2016/09/27 20:24:45 Hmm, I have no idea why this if check was initiall
maxbogue 2016/09/28 20:17:09 Who knowssss!
- LoadModelsDone(UNRECOVERABLE_ERROR, error);
- }
+ LoadModelsDone(UNRECOVERABLE_ERROR, error);
}
void NonBlockingDataTypeController::RecordStartFailure(
« components/sync/driver/data_type_manager_impl.cc ('K') | « components/sync/driver/data_type_manager_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698