Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2369063002: [DevTools] Make empty matched styles section zero-height. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make empty matched styles section zero-height. Regressed when styles section moved to TreeOutlineInShadow. BUG=649556 Committed: https://crrev.com/ee7d870880f6e38b26913c2c661a03f5c90c90c7 Cr-Commit-Position: refs/heads/master@{#420992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-09-26 16:16:36 UTC) #2
lushnikov
lgtm
4 years, 2 months ago (2016-09-26 16:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369063002/1
4 years, 2 months ago (2016-09-26 17:58:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 21:12:38 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 21:14:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee7d870880f6e38b26913c2c661a03f5c90c90c7
Cr-Commit-Position: refs/heads/master@{#420992}

Powered by Google App Engine
This is Rietveld 408576698