Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2369053002: [Cronet] Use WeakPtr in CronetBidirectionalStream on iOS. (Closed)

Created:
4 years, 2 months ago by mef
Modified:
4 years, 2 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Use WeakPtr in CronetBidirectionalStream on iOS. BUG=650782 Committed: https://crrev.com/ce9fb501c0aa11c21d26f7701c3fdf542fb58c22 Cr-Commit-Position: refs/heads/master@{#421302}

Patch Set 1 #

Patch Set 2 : Remove build/config/sanitizers/BUILD.gn changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M components/cronet/ios/cronet_bidirectional_stream.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/cronet/ios/cronet_bidirectional_stream.cc View 8 chunks +16 lines, -10 lines 0 comments Download
M components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
mef
Here is my fix.
4 years, 2 months ago (2016-09-26 16:32:06 UTC) #2
kapishnikov
lgtm
4 years, 2 months ago (2016-09-26 17:57:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369053002/20001
4 years, 2 months ago (2016-09-27 18:09:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369053002/20001
4 years, 2 months ago (2016-09-27 19:36:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 19:46:36 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:49:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce9fb501c0aa11c21d26f7701c3fdf542fb58c22
Cr-Commit-Position: refs/heads/master@{#421302}

Powered by Google App Engine
This is Rietveld 408576698