[Sync] Always upload stack traces for USS DeviceInfo.

[Sync] Always upload stack traces for USS DeviceInfo.

BUG=650861
Committed: https://crrev.com/c1bbd816347464ee3e4b9b2110113ec37c7c78ce
Cr-Commit-Position: refs/heads/master@{#421386}

[maxbogue, 2016-09-27 22:34:34]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 22:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-27 22:38:45]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-09-27 22:38:46]

Sky, PTAL! +cc Pavel FYI

[commit-bot: I haz the power, 2016-09-27 23:18:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:18:55]

Dry run: This issue passed the CQ dry run.

[skym, 2016-09-27 23:22:40]

lgtm

Not exactly what I had in mind, but this is certainly fine as well.

https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_components_factory_impl.cc:154:
syncer::DEVICE_INFO, base::Bind(&base::debug::DumpWithoutCrashing),
Hmm I was more thinking that we'd control the % with a finch param.

[maxbogue, 2016-09-27 23:37:33]

https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_components_factory_impl.cc:154:
syncer::DEVICE_INFO, base::Bind(&base::debug::DumpWithoutCrashing),
On 2016/09/27 23:22:39, skym wrote:
> Hmm I was more thinking that we'd control the % with a finch param.

I think this is more something we'll want to have for a little while during the
rollout and then switch back as soon as we're confident there aren't many
crashes.

[maxbogue, 2016-09-27 23:37:39]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:43:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 23:45:13]

Description was changed from

==========
[Sync] Always upload stack traces for USS DeviceInfo.

BUG=650861
==========

to

==========
[Sync] Always upload stack traces for USS DeviceInfo.

BUG=650861

Committed: https://crrev.com/c1bbd816347464ee3e4b9b2110113ec37c7c78ce
Cr-Commit-Position: refs/heads/master@{#421386}
==========

[commit-bot: I haz the power, 2016-09-27 23:45:14]

Patchset 1 (id:??) landed as
https://crrev.com/c1bbd816347464ee3e4b9b2110113ec37c7c78ce
Cr-Commit-Position: refs/heads/master@{#421386}