Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2369033005: [Sync] Always upload stack traces for USS DeviceInfo. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org, pavely
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Always upload stack traces for USS DeviceInfo. BUG=650861 Committed: https://crrev.com/c1bbd816347464ee3e4b9b2110113ec37c7c78ce Cr-Commit-Position: refs/heads/master@{#421386}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/browser_sync/profile_sync_components_factory_impl.cc View 2 chunks +6 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
maxbogue
Sky, PTAL! +cc Pavel FYI
4 years, 2 months ago (2016-09-27 22:38:46 UTC) #4
skym
lgtm Not exactly what I had in mind, but this is certainly fine as well. ...
4 years, 2 months ago (2016-09-27 23:22:40 UTC) #7
maxbogue
https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/profile_sync_components_factory_impl.cc File components/browser_sync/profile_sync_components_factory_impl.cc (right): https://codereview.chromium.org/2369033005/diff/1/components/browser_sync/profile_sync_components_factory_impl.cc#newcode154 components/browser_sync/profile_sync_components_factory_impl.cc:154: syncer::DEVICE_INFO, base::Bind(&base::debug::DumpWithoutCrashing), On 2016/09/27 23:22:39, skym wrote: > Hmm ...
4 years, 2 months ago (2016-09-27 23:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369033005/1
4 years, 2 months ago (2016-09-27 23:37:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 23:43:35 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 23:45:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1bbd816347464ee3e4b9b2110113ec37c7c78ce
Cr-Commit-Position: refs/heads/master@{#421386}

Powered by Google App Engine
This is Rietveld 408576698