[interpreter] Fix the interface descriptor for interpreter dispatch.

[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=

Committed: https://crrev.com/0fb486fe444c48fa4b3cdcd4ff3d8a83858cb941
Cr-Commit-Position: refs/heads/master@{#39777}

[epertoso, 2016-09-27 13:58:44]

Description was changed from

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's a pointer.

BUG=
==========

to

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's a pointer.

BUG=
==========

[epertoso, 2016-09-27 13:58:44]

epertoso@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[epertoso, 2016-09-27 14:00:10]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:00:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-09-27 14:01:27]

https://codereview.chromium.org/2369033003/diff/1/src/interface-descriptors.cc
File src/interface-descriptors.cc (right):

https://codereview.chromium.org/2369033003/diff/1/src/interface-descriptors.c...
src/interface-descriptors.cc:421: MachineType::AnyTagged(),
MachineType::Pointer(),
Should it not be IntPtr() ?  It isn't really a pointer, it is just an offset
which is added to a tagged pointer.

[epertoso, 2016-09-27 14:03:58]

https://codereview.chromium.org/2369033003/diff/1/src/interface-descriptors.cc
File src/interface-descriptors.cc (right):

https://codereview.chromium.org/2369033003/diff/1/src/interface-descriptors.c...
src/interface-descriptors.cc:421: MachineType::AnyTagged(),
MachineType::Pointer(),
On 2016/09/27 14:01:27, rmcilroy wrote:
> Should it not be IntPtr() ?  It isn't really a pointer, it is just an offset
> which is added to a tagged pointer.

Oops. Done.

[epertoso, 2016-09-27 14:09:41]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-09-27 14:12:55]

Please update the description (pointer->IntPtr), but LGTM otherwise.

[epertoso, 2016-09-27 14:15:40]

Description was changed from

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's a pointer.

BUG=
==========

to

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=
==========

[epertoso, 2016-09-27 14:45:16]

On 2016/09/27 14:12:55, rmcilroy wrote:
> Please update the description (pointer->IntPtr), but LGTM otherwise.

Done.

[commit-bot: I haz the power, 2016-09-27 14:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:45:24]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-09-27 14:45:36]

The CQ bit was checked by epertoso@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:45:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:00:01]

Description was changed from

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=
==========

to

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=
==========

[commit-bot: I haz the power, 2016-09-27 15:00:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 15:00:22]

Description was changed from

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=
==========

to

==========
[interpreter] Fix the interface descriptor for interpreter dispatch.

The bytecode offset parameter was Int32, but everywhere else it's an IntPtr.

BUG=

Committed: https://crrev.com/0fb486fe444c48fa4b3cdcd4ff3d8a83858cb941
Cr-Commit-Position: refs/heads/master@{#39777}
==========

[commit-bot: I haz the power, 2016-09-27 15:00:24]

Patchset 2 (id:??) landed as
https://crrev.com/0fb486fe444c48fa4b3cdcd4ff3d8a83858cb941
Cr-Commit-Position: refs/heads/master@{#39777}