Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2369033002: GN: detect is_clang, use it to switch Clang to warning blacklist. (Closed)

Created:
4 years, 2 months ago by mtklein_C
Modified:
4 years, 2 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: detect is_clang, use it to switch Clang to warning blacklist. Same as the last CL, now with -Wno-over-aligned. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369033002 TBR=bungeman@google.com NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/f347c51226cbad94b48bd6befdcddda04b6c8c62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M gn/BUILD.gn View 2 chunks +75 lines, -0 lines 0 comments Download
A gn/is_clang.py View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mtklein_C
4 years, 2 months ago (2016-09-26 14:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369033002/1
4 years, 2 months ago (2016-09-26 14:41:10 UTC) #7
bungeman-skia
lgtm even more
4 years, 2 months ago (2016-09-26 14:49:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369033002/1
4 years, 2 months ago (2016-09-26 15:38:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 15:40:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f347c51226cbad94b48bd6befdcddda04b6c8c62

Powered by Google App Engine
This is Rietveld 408576698