Log host and client screen sizes.

remoting/webapp/base/js/session_logger.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
@@ skipping 245 matching lines @@
   this.statsAccumulator_.add(stats);
   // Send statistics to the server if they've been accumulating for at least
   // 60 seconds.
   if (this.statsAccumulator_.getTimeSinceFirstValue() >=
       remoting.SessionLogger.CONNECTION_STATS_ACCUMULATE_TIME) {
     this.logAccumulatedStatistics_();
   }
 };
 
 /**
+ * Logs host and client dimensions.
+ *
+ * @param {{width: number, height: number}} hostSize
+ * @param {{width: number, height: number}} clientPluginSize
+ * @param {{width: number, height: number}} clientWindowSize
+ * @param {boolean} clientFullscreen
+ */
+remoting.SessionLogger.prototype.logScreenResolutions =
+    function(hostSize, clientPluginSize, clientWindowSize, clientFullscreen) {

[Lambros, 2016/09/28 21:47:57]

clientVideoSize instead of clientPluginSize ?
(here and elsewhere)

[Jamie, 2016/09/28 22:09:29]

I went with plugin instead of video here because it is a plugin for this
implementation (and we refer to it such fairly consistently). For the protobuf,
I think video makes more sense, since that's what it is more generally, but it
does mean changing nomenclature between the two  in this code-base.

+  this.maybeExpireSessionId_();
+  var entry = this.makeScreenResolutions_(hostSize, clientPluginSize,
+                                          clientWindowSize, clientFullscreen);
+  this.log_(entry);
+};
+
+/**
  * @param {remoting.ChromotingEvent.SessionState} state
  * @param {remoting.Error=} opt_error
  * @return {remoting.ChromotingEvent}
  * @private
  */
 remoting.SessionLogger.prototype.makeSessionStateChange_ =
     function(state, opt_error) {
   var entry = new remoting.ChromotingEvent(
       remoting.ChromotingEvent.Type.SESSION_STATE);
 
   var ConnectionError = remoting.ChromotingEvent.ConnectionError;
 
   if (!opt_error) {
     entry.connection_error = ConnectionError.NONE;
   } else if (opt_error instanceof remoting.Error) {
     entry.setError(opt_error);
   } else {
     entry.connection_error = ConnectionError.UNKNOWN_ERROR;
   }
 
   entry.session_state = state;
 
   this.fillEvent_(entry);
   return entry;
 };
 
 /**
+ * @param {{width: number, height: number}} hostSize
+ * @param {{width: number, height: number}} clientPluginSize
+ * @param {{width: number, height: number}} clientWindowSize
+ * @param {boolean} clientFullscreen
+ * @return {remoting.ChromotingEvent}
+ * @private
+ */
+remoting.SessionLogger.prototype.makeScreenResolutions_ =
+    function(hostSize, clientPluginSize, clientWindowSize, clientFullscreen) {
+  var entry = new remoting.ChromotingEvent(
+      remoting.ChromotingEvent.Type.SCREEN_RESOLUTIONS);
+  entry.client_video_size = new remoting.ChromotingEvent.ScreenResolution(
+      clientPluginSize.width, clientPluginSize.height);
+  entry.client_window_size = new remoting.ChromotingEvent.ScreenResolution(
+      clientWindowSize.width, clientWindowSize.height);
+  entry.host_all_screens_size = new remoting.ChromotingEvent.ScreenResolution(
+      hostSize.width, hostSize.height);
+  entry.client_fullscreen = clientFullscreen;
+  this.fillEvent_(entry);
+  return entry;
+};
+
+/**
  * @return {remoting.ChromotingEvent}
  * @private
  */
 remoting.SessionLogger.prototype.makeSessionIdNew_ = function() {
   var entry = new remoting.ChromotingEvent(
       remoting.ChromotingEvent.Type.SESSION_ID_NEW);
   this.fillEvent_(entry);
   return entry;
 };
 
@@ skipping 211 matching lines @@
 }
 
 // The maximum age of a session ID, in milliseconds.
 remoting.SessionLogger.MAX_SESSION_ID_AGE = 24 * 60 * 60 * 1000;
 
 // The time over which to accumulate connection statistics before logging them
 // to the server, in milliseconds.
 remoting.SessionLogger.CONNECTION_STATS_ACCUMULATE_TIME = 60 * 1000;
 
 })();