Log host and client screen sizes.

remoting/webapp/crd/js/desktop_viewport.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Provides view port management utilities below for a desktop remoting session.
  * - Enabling bump scrolling
  * - Resizing the viewport to fit the host desktop
  * - Resizing the host desktop to fit the client viewport.
  */
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
 
 /**
  * @param {HTMLElement} rootElement The outer element with id=scroller that we
  *   are showing scrollbars on.
  * @param {remoting.HostDesktop} hostDesktop
  * @param {remoting.HostOptions} hostOptions
+ * @param {!remoting.SessionLogger} logger
  *
  * @constructor
  * @implements {base.Disposable}
  */
-remoting.DesktopViewport = function(rootElement, hostDesktop, hostOptions) {
+  remoting.DesktopViewport = function(rootElement, hostDesktop, hostOptions,
+                                      logger) {
   /** @private */
   this.rootElement_ = rootElement;
   /** @private */
   // TODO(kelvinp): Query the container by class name instead of id.
   this.pluginContainer_ = rootElement.querySelector('#client-container');
   /** @private */
   this.pluginElement_ = rootElement.querySelector('embed');
   /** @private */
   this.hostDesktop_ = hostDesktop;
   /** @private */
   this.hostOptions_ = hostOptions;
   /** @private {number?} */
   this.resizeTimer_ = null;
   /** @private {remoting.BumpScroller} */
   this.bumpScroller_ = null;
   // Bump-scroll test variables. Override to use a fake value for the width
   // and height of the client plugin so that bump-scrolling can be tested
   // without relying on the actual size of the host desktop.
   /** @private {number} */
   this.pluginWidthForBumpScrollTesting_ = 0;
   /** @private {number} */
   this.pluginHeightForBumpScrollTesting_ = 0;
+  /** @private {!remoting.SessionLogger} */
+  this.logger_ = logger;
+  /** @private {number?} */
+  this.loggingTimer_ = null;
 
   this.eventHooks_ = new base.Disposables(
       new base.EventHook(
         this.hostDesktop_, remoting.HostDesktop.Events.sizeChanged,
         this.onDesktopSizeChanged_.bind(this)));
 
   if (this.hostOptions_.getResizeToClient()) {
     this.resizeHostDesktop_();
   } else {
     this.onDesktopSizeChanged_();
@@ skipping 262 matching lines @@
 remoting.DesktopViewport.prototype.updateDimensions_ = function() {
   var dimensions = this.hostDesktop_.getDimensions();
   if (dimensions.width === 0 || dimensions.height === 0) {
     return;
   }
 
   var desktopSize = { width: dimensions.width,
                       height: dimensions.height };
   var desktopDpi = { x: dimensions.xDpi,
                      y: dimensions.yDpi };
+  var clientSize = this.getClientArea();
   var newSize = remoting.Viewport.choosePluginSize(
-      this.getClientArea(), window.devicePixelRatio,
+      clientSize, window.devicePixelRatio,
       desktopSize, desktopDpi, this.hostOptions_.getDesktopScale(),
       remoting.fullscreen.isActive(), this.hostOptions_.getShrinkToFit());
 
+  this.logDimensions_(desktopSize, clientSize, remoting.fullscreen.isActive());

[Lambros, 2016/09/28 01:30:39]

Would it make more sense to log the plugin size instead of the client area?

[Jamie, 2016/09/28 21:14:36]

I think there's value in both. Client area is probably more useful because it
tells us how the client is being used, independent of the host desktop size.
I've added the plugin size too, since I can think of use-cases for that.

+
   // Resize the plugin if necessary.
   console.log('plugin dimensions:' + newSize.width + 'x' + newSize.height);
   this.pluginElement_.style.width = newSize.width + 'px';
   this.pluginElement_.style.height = newSize.height + 'px';
 };
 
 /** @private */
 remoting.DesktopViewport.prototype.resetScroll_ = function() {
   this.pluginContainer_.style.marginTop = '0px';
   this.pluginContainer_.style.marginLeft = '0px';
@@ skipping 10 matching lines @@
   this.hostOptions_.setDesktopScale(desktopScale);
 
   // onResize() will update the plugin size and scrollbars for the new
   // scaled plugin dimensions, and send a client resolution notification.
   this.onResize();
 
   // Save the new desktop scale setting.
   this.hostOptions_.save();
 };
 
+/**
+ * Log the specified client and host sizes after a short delay. Since the host
+ * size may change in response to a change in the client size, the delay allows
+ * time for the desktop size change notification to arrive from the host, and
+ * avoids logging the intermediate state.
+ */
+remoting.DesktopViewport.prototype.logDimensions_ =
+    function(hostSize, clientSize, isFullscreen) {
+  if (this.loggingTimer_ !== null) {
+    window.clearTimeout(this.loggingTimer_);
+  }
+  var kLoggingRateLimitMs = 2000;
+  this.loggingTimer_ = window.setTimeout(
+      () => {
+        this.logger_.logScreenResolutions(hostSize, clientSize, isFullscreen);
+      },
+      kLoggingRateLimitMs);
+};
+
 }());