Log host and client screen sizes.

Log host and client screen sizes.

BUG=642519
Committed: https://crrev.com/ce29dde501a0f4d4531118b80b0c0a64aae820a1
Cr-Commit-Position: refs/heads/master@{#422952}

[Jamie, 2016-09-28 01:02:16]

jamiewalch@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Jamie, 2016-09-28 01:02:17]

ptal

[Lambros, 2016-09-28 01:30:40]

lgtm

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/server_log_entry.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/server_log_entry.js:180: 
Only whitespace changes in this file.

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/session_logger.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/session_logger.js:266: * Logs connection statistics.
Wrong comment.

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_viewport.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_viewport.js:346: this.logDimensions_(desktopSize,
clientSize, remoting.fullscreen.isActive());
Would it make more sense to log the plugin size instead of the client area?

[Jamie, 2016-09-28 21:14:37]

PTAL.

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/server_log_entry.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/server_log_entry.js:180: 
On 2016/09/28 01:30:39, Lambros wrote:
> Only whitespace changes in this file.

Done.

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/session_logger.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/session_logger.js:266: * Logs connection statistics.
On 2016/09/28 01:30:39, Lambros wrote:
> Wrong comment.

Done.

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_viewport.js (right):

https://codereview.chromium.org/2369013008/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_viewport.js:346: this.logDimensions_(desktopSize,
clientSize, remoting.fullscreen.isActive());
On 2016/09/28 01:30:39, Lambros wrote:
> Would it make more sense to log the plugin size instead of the client area?

I think there's value in both. Client area is probably more useful because it
tells us how the client is being used, independent of the host desktop size.
I've added the plugin size too, since I can think of use-cases for that.

[Lambros, 2016-09-28 21:47:57]

Still lgtm, just a question about naming.

https://codereview.chromium.org/2369013008/diff/40001/remoting/webapp/base/js...
File remoting/webapp/base/js/session_logger.js (right):

https://codereview.chromium.org/2369013008/diff/40001/remoting/webapp/base/js...
remoting/webapp/base/js/session_logger.js:274: function(hostSize,
clientPluginSize, clientWindowSize, clientFullscreen) {
clientVideoSize instead of clientPluginSize ?
(here and elsewhere)

[Jamie, 2016-09-28 22:09:29]

https://codereview.chromium.org/2369013008/diff/40001/remoting/webapp/base/js...
File remoting/webapp/base/js/session_logger.js (right):

https://codereview.chromium.org/2369013008/diff/40001/remoting/webapp/base/js...
remoting/webapp/base/js/session_logger.js:274: function(hostSize,
clientPluginSize, clientWindowSize, clientFullscreen) {
On 2016/09/28 21:47:57, Lambros wrote:
> clientVideoSize instead of clientPluginSize ?
> (here and elsewhere)

I went with plugin instead of video here because it is a plugin for this
implementation (and we refer to it such fairly consistently). For the protobuf,
I think video makes more sense, since that's what it is more generally, but it
does mean changing nomenclature between the two  in this code-base.

[Jamie, 2016-10-04 21:18:10]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2016-10-04 21:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/2369013008/#ps60001
(title: "Add DPI.")

[commit-bot: I haz the power, 2016-10-04 21:19:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:06:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-04 22:08:55]

Description was changed from

==========
Log host and client screen sizes.

BUG=642519
==========

to

==========
Log host and client screen sizes.

BUG=642519

Committed: https://crrev.com/ce29dde501a0f4d4531118b80b0c0a64aae820a1
Cr-Commit-Position: refs/heads/master@{#422952}
==========

[commit-bot: I haz the power, 2016-10-04 22:08:56]

Patchset 4 (id:??) landed as
https://crrev.com/ce29dde501a0f4d4531118b80b0c0a64aae820a1
Cr-Commit-Position: refs/heads/master@{#422952}