Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2369013004:
Prepare for per thread heap on service worker thread. (Closed)
|
Created:
4 years, 2 months ago by keishi Modified:
4 years, 2 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrepare for per thread heap on service worker thread.
ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent.
BUG=591606
Committed: https://crrev.com/097490296ebb78772f2b058e7f2b144894a4197e
Cr-Commit-Position: refs/heads/master@{#421715}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable pth on service worker BUG= ========== to ========== Prepare for per thread heap on service worker thread. ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent. BUG=591606 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
keishi@chromium.org changed reviewers: + haraken@chromium.org, nhiroki@chromium.org, oilpan-reviews@chromium.org
PTAL
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by keishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Prepare for per thread heap on service worker thread. ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent. BUG=591606 ========== to ========== Prepare for per thread heap on service worker thread. ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent. BUG=591606 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Prepare for per thread heap on service worker thread. ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent. BUG=591606 ========== to ========== Prepare for per thread heap on service worker thread. ServiceWorkerGlobalScope is created in the worker thread and ServiceWorkerGlobalScopeProxy is created in the main thread so the handle should be a CrossThreadPersistent. BUG=591606 Committed: https://crrev.com/097490296ebb78772f2b058e7f2b144894a4197e Cr-Commit-Position: refs/heads/master@{#421715} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/097490296ebb78772f2b058e7f2b144894a4197e Cr-Commit-Position: refs/heads/master@{#421715}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
