Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2369003003: Set string-prototype-properties to NeedsManualRebaseline (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set string-prototype-properties to NeedsManualRebaseline The expectations incorrectly expect 'subString' instead of 'substring' in the case when substring is called on null or undefined. BUG=chromium:650247 Committed: https://crrev.com/f3cf8d5ad4bac5e75d51e9da0fd503cff525b050 Cr-Commit-Position: refs/heads/master@{#421140}

Patch Set 1 #

Patch Set 2 : Set string-prototype-properties to NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jgruber
4 years, 2 months ago (2016-09-26 13:30:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-26 15:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369003003/1
4 years, 2 months ago (2016-09-27 06:51:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 07:49:48 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:51:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3cf8d5ad4bac5e75d51e9da0fd503cff525b050
Cr-Commit-Position: refs/heads/master@{#421140}

Powered by Google App Engine
This is Rietveld 408576698