Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2369003002: Revert of [stubs] Port String.prototype.substring to TurboFan (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko, jgruber
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Port String.prototype.substring to TurboFan (patchset #5 id:80001 of https://codereview.chromium.org/2358133004/ ) Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10075 Original issue's description: > [stubs] Port String.prototype.substring to TurboFan > > BUG=v8:5415 > > Committed: https://crrev.com/cc37dff7ba21345b3a867a86127a208e34a3f707 > Cr-Commit-Position: refs/heads/master@{#39717} TBR=ishell@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5415 Committed: https://crrev.com/0e2155ad5704f72824798f2cc51cdb9c6686560f Cr-Commit-Position: refs/heads/master@{#39724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -115 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M src/js/i18n.js View 2 chunks +2 lines, -1 line 0 comments Download
M src/js/string.js View 3 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [stubs] Port String.prototype.substring to TurboFan
4 years, 2 months ago (2016-09-26 13:16:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369003002/1
4 years, 2 months ago (2016-09-26 13:16:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 13:17:08 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 13:17:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e2155ad5704f72824798f2cc51cdb9c6686560f
Cr-Commit-Position: refs/heads/master@{#39724}

Powered by Google App Engine
This is Rietveld 408576698