Issue 23690005: Allow configuring CPU profiler sampling interval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23690005: Allow configuring CPU profiler sampling interval (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
pfeldman, loislo

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Allow configuring CPU profiler sampling interval Added a setting for selecting higher sampling rate for CPU profiler 0.1ms sampling interval vs. default 1ms one. BUG=v8:2814 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158180

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -1 line)			Patch
M	Source/bindings/v8/ScriptProfiler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptProfiler.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.cpp	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ProfilesPanel.js	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/Settings.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/SettingsScreen.js	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/devtools/protocol.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

This is a slightly modified version of r157301 which was rolled out in r157359 due ...

7 years, 3 months ago (2013-09-06 09:55:52 UTC) #1

yurys

Committed patchset #1 manually as r158180 (presubmit successful).

7 years, 3 months ago (2013-09-23 12:56:29 UTC) #3

pfeldman

7 years, 3 months ago (2013-09-23 14:26:54 UTC) #4

Message was sent while issue was closed.

This change broke the build. Please use try bots and CQ.

Expand Messages | Collapse Messages