tests/PathOpsConicIntersectionTest.cpp - Issue 2368993002: allow conic chop to fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathOpsConicIntersectionTest.cpp

Issue 2368993002: allow conic chop to fail (Closed)

Patch Set: address comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathOpsConicIntersectionTest.cpp

diff --git a/tests/PathOpsConicIntersectionTest.cpp b/tests/PathOpsConicIntersectionTest.cpp

index 624a68adaf93d28ae144e706b471680af360c2df..e22ad6bff116ed711f4b285a3c39d5dbd2017c8f 100644

--- a/tests/PathOpsConicIntersectionTest.cpp

+++ b/tests/PathOpsConicIntersectionTest.cpp

@@ -165,7 +165,9 @@ static void chopBothWays(const SkDConic& dConic, double t, const char* name) {

conic.fW = dConic.fWeight;

SkConic chopped[2];

SkDConic dChopped[2];

- conic.chopAt(SkDoubleToScalar(t), chopped);

+ if (!conic.chopAt(SkDoubleToScalar(t), chopped)) {

+ return;

+ }

dChopped[0] = dConic.subDivide(0, t);

dChopped[1] = dConic.subDivide(t, 1);

#if DEBUG_VISUALIZE_CONICS

« no previous file with comments | « src/pathops/SkOpEdgeBuilder.cpp ('k') | tests/PathOpsOpTest.cpp » ('j') | no next file with comments »