Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2368993002: allow conic chop to fail (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

allow conic chop to fail Fuzzy values may cause the conic chop to fail. Check to see if the values are all finite, and require the caller to do the same. R=reed@google.com BUG=650178 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002 Committed: https://skia.googlesource.com/skia/+/414c4295f951d43068666b6294df15b2fd2ba85c

Patch Set 1 #

Patch Set 2 : fix more callers #

Total comments: 2

Patch Set 3 : fix sampleapp #

Patch Set 4 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -19 lines) Patch
M gm/beziereffects.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M samplecode/SampleAAGeometry.cpp View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M src/core/SkGeometry.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGeometry.cpp View 1 2 3 4 chunks +18 lines, -6 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M tests/PathOpsConicIntersectionTest.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
caryclark
4 years, 2 months ago (2016-09-26 13:03:32 UTC) #3
reed1
lgtm https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp#newcode1007 src/core/SkGeometry.cpp:1007: return SkScalarsAreFinite(&dst[0].fPts[0].fX, 7) && SkScalarsAreFinite(&dst[1].fPts[0].fX, 7); SkScalarsAreFinite(&dst[0].fPts[0].fX, 14) ...
4 years, 2 months ago (2016-09-26 15:25:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368993002/20001
4 years, 2 months ago (2016-09-26 15:27:59 UTC) #13
caryclark
Oops, broke SampleApp. Will fix, test, upload.
4 years, 2 months ago (2016-09-26 16:10:37 UTC) #15
caryclark
https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp#newcode1007 src/core/SkGeometry.cpp:1007: return SkScalarsAreFinite(&dst[0].fPts[0].fX, 7) && SkScalarsAreFinite(&dst[1].fPts[0].fX, 7); On 2016/09/26 15:25:26, ...
4 years, 2 months ago (2016-09-26 17:10:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368993002/60001
4 years, 2 months ago (2016-09-26 18:02:39 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:04:00 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/414c4295f951d43068666b6294df15b2fd2ba85c

Powered by Google App Engine
This is Rietveld 408576698