allow conic chop to fail

allow conic chop to fail

Fuzzy values may cause the conic chop to fail.

Check to see if the values are all finite, and
require the caller to do the same.

R=reed@google.com
BUG=650178
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002

Committed: https://skia.googlesource.com/skia/+/414c4295f951d43068666b6294df15b2fd2ba85c

[caryclark, 2016-09-26 13:01:28]

Description was changed from

==========
allow conic chop to fail

Fuzzy values may cause the conic chop to fail.

Check to see if the values are all finite, and
require the caller to do the same.

R=reed@google.com
BUG=650178
==========

to

==========
allow conic chop to fail

Fuzzy values may cause the conic chop to fail.

Check to see if the values are all finite, and
require the caller to do the same.

R=reed@google.com
BUG=650178
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002
==========

[caryclark, 2016-09-26 13:03:27]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:03:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 13:05:04]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[caryclark, 2016-09-26 13:29:15]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 13:49:14]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-26 15:25:26]

lgtm

https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp...
src/core/SkGeometry.cpp:1007: return SkScalarsAreFinite(&dst[0].fPts[0].fX, 7)
&& SkScalarsAreFinite(&dst[1].fPts[0].fX, 7);
SkScalarsAreFinite(&dst[0].fPts[0].fX, 14) ?

[caryclark, 2016-09-26 15:27:44]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-09-26 15:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-09-26 16:09:55]

The CQ bit was unchecked by caryclark@google.com

[caryclark, 2016-09-26 16:10:37]

Oops, broke SampleApp. Will fix, test, upload.

[caryclark, 2016-09-26 17:10:33]

https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/2368993002/diff/20001/src/core/SkGeometry.cpp...
src/core/SkGeometry.cpp:1007: return SkScalarsAreFinite(&dst[0].fPts[0].fX, 7)
&& SkScalarsAreFinite(&dst[1].fPts[0].fX, 7);
On 2016/09/26 15:25:26, reed1 wrote:
> SkScalarsAreFinite(&dst[0].fPts[0].fX, 14) ?

Done.

[caryclark, 2016-09-26 17:10:44]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:52:29]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-09-26 18:02:31]

The CQ bit was checked by caryclark@google.com

[caryclark, 2016-09-26 18:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2368993002/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-09-26 18:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:03:56]

Description was changed from

==========
allow conic chop to fail

Fuzzy values may cause the conic chop to fail.

Check to see if the values are all finite, and
require the caller to do the same.

R=reed@google.com
BUG=650178
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002
==========

to

==========
allow conic chop to fail

Fuzzy values may cause the conic chop to fail.

Check to see if the values are all finite, and
require the caller to do the same.

R=reed@google.com
BUG=650178
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002

Committed:
https://skia.googlesource.com/skia/+/414c4295f951d43068666b6294df15b2fd2ba85c
==========

[commit-bot: I haz the power, 2016-09-26 18:04:00]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/414c4295f951d43068666b6294df15b2fd2ba85c