Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2368933003:
Tag checkerboard bitmaps as sRGB (Closed)
|
Created:
4 years, 2 months ago by Brian Osman Modified:
4 years, 2 months ago CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionTag checkerboard bitmaps as sRGB
Significantly reduces the diff between legacy and sRGB/F16 on about 25
GMs. This is just the biggest piece of low-hanging fruit. Many GMs create
N32 raster surfaces to procedurally generate source textures, and I'd like
to fix all of them. It's much easier to reason about the GMs (is sRGB
doing the right thing) when everything is tagged like this - the only
expected differences are due to filtering and blending.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003
Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7
Committed: https://skia.googlesource.com/skia/+/2331a5f2e061254206510cf8ab59e16f8c4921a2
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: ========== to ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 ==========
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
brianosman@google.com changed reviewers: + mtklein@google.com, reed@google.com, robertphillips@google.com
lgtm
The CQ bit was unchecked by brianosman@google.com
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 ========== to ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2375063002/ by brianosman@google.com. The reason for reverting is: Regression on displacement GM when sRGB support is lacking..
Message was sent while issue was closed.
Description was changed from ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 ========== to ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 ==========
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 ========== to ========== Tag checkerboard bitmaps as sRGB Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 Committed: https://skia.googlesource.com/skia/+/2331a5f2e061254206510cf8ab59e16f8c4921a2 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2331a5f2e061254206510cf8ab59e16f8c4921a2 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
