content/test/data/browsing_data/worker_setup.html - Issue 2368923003: Support the Clear-Site-Data header on resource requests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/browsing_data/worker_setup.html

Issue 2368923003: Support the Clear-Site-Data header on resource requests (Closed)

Patch Set: Addressed comments, improved the SW test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!-- Testing page used in ClearSiteDataThrottleTest. -->

	2

	3 <html>

	4 <head>

	5 </head>

	6 <body>

	7 <img id="some_resource" />

	8

	9 <script>

	10 // Set up a service worker to handle future requests.

	11 navigator.serviceWorker.register('/?file=worker.js').then(function() {

	12 // Inform the C++ side of this test that the worker is now registered.

	13 document.title = 'service worker registered';

	14 console.log('Service worker registered.');
	falken 2016/10/19 07:14:38 This isn't quite right, the service worker is stil This isn't quite right, the service worker is still being installed at this point, so it won't intercept fetches. You should wait for it to activate. You can do this using .ready: navigator.serviceWorker.register('/?file=worker.js') .then(() => navigator.serviceWorker.ready) .then(() => { document.title = 'service worker is ready'; }); .catch(err => { console.log('error'); }); msramek 2016/10/19 12:20:12 Done. I just left out the catch() part, as the exc Show quoted text On 2016/10/19 07:14:38, falken wrote: > This isn't quite right, the service worker is still being installed at this > point, so it won't intercept fetches. You should wait for it to activate. You > can do this using .ready: > > navigator.serviceWorker.register('/?file=worker.js') > .then(() => navigator.serviceWorker.ready) > .then(() => { document.title = 'service worker is ready'; }); > .catch(err => { console.log('error'); }); Done. I just left out the catch() part, as the exception will be logged to the console automatically, and it's more informative than a generic error message.
	15 });

	16 </script>

	17 </body>

	18 </html>

OLD	NEW

« content/test/data/browsing_data/worker.js ('K') | « content/test/data/browsing_data/worker.js ('k') | no next file » | no next file with comments »