Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/browser/loader/navigation_resource_handler.cc

Issue 2368913002: Fix stream errors that occur after a stream starts not propagating. (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_resource_handler.cc
diff --git a/content/browser/loader/navigation_resource_handler.cc b/content/browser/loader/navigation_resource_handler.cc
index 150a10f7853fdefcedb90708c1fc85e11334751f..5ed02e805ead54a86f2cf39e36f2a78c6a6064c4 100644
--- a/content/browser/loader/navigation_resource_handler.cc
+++ b/content/browser/loader/navigation_resource_handler.cc
@@ -163,11 +163,8 @@ void NavigationResourceHandler::OnResponseCompleted(
const net::URLRequestStatus& status,
bool* defer) {
// If the request has already committed, close the stream and leave it as-is.
- //
- // TODO(davidben): The net error code should be passed through StreamWriter
- // down to the stream's consumer. See https://crbug.com/426162.
if (writer_.stream()) {
- writer_.Finalize();
+ writer_.Finalize(status.error());
return;
}

Powered by Google App Engine
This is Rietveld 408576698