Fix stream errors that occur after a stream starts not propagating.

content/browser/streams/stream_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "content/browser/streams/stream.h"
@@ skipping 43 matching lines @@
     while (true) {
       Stream::StreamState state =
           stream->ReadRawData(buffer.get(), kBufferSize, &bytes_read);
       switch (state) {
         case Stream::STREAM_HAS_DATA:
           // TODO(tyoshino): Move these expectations to the beginning of Read()
           // method once Stream::Finalize() is fixed.
           EXPECT_FALSE(completed_);
           break;
         case Stream::STREAM_COMPLETE:
           completed_ = true;

[tyoshino (SeeGerritForStatus), 2016/09/27 10:24:56]

save GetStatus() here and export as status()?

[jam, 2016/09/27 15:41:07]

Done.

           return;
         case Stream::STREAM_EMPTY:
           EXPECT_FALSE(completed_);
           return;
         case Stream::STREAM_ABORTED:
           aborted_ = true;
           EXPECT_FALSE(completed_);
           return;
       }
       size_t old_capacity = buffer_->capacity();
@@ skipping 113 matching lines @@
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream(
       new Stream(registry_.get(), &writer, url));
   EXPECT_TRUE(stream->SetReadObserver(&reader));
 
   const int kBufferSize = 1000000;
   scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
   writer.Write(stream.get(), buffer, kBufferSize);
-  stream->Finalize();
+  stream->Finalize(0);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(reader.completed());

[tyoshino (SeeGerritForStatus), 2016/09/27 10:24:56]

check status() here

and could you please add a test case where an instantiated Stream is immediately
Finalize()-ed with some non-zero value and check whether or not status() is set
to the value?

[jam, 2016/09/27 15:41:07]

Done.

 
   ASSERT_EQ(reader.buffer()->capacity(), kBufferSize);
   for (int i = 0; i < kBufferSize; i++)
     EXPECT_EQ(buffer->data()[i], reader.buffer()->data()[i]);
 }
 
 TEST_F(StreamTest, Abort) {
   TestStreamReader reader;
   TestStreamWriter writer;
 
@@ skipping 18 matching lines @@
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream(
       new Stream(registry_.get(), &writer, url));
   EXPECT_TRUE(stream->SetReadObserver(&reader));
 
   const int kBufferSize = 0;
   scoped_refptr<net::IOBuffer> buffer(NewIOBuffer(kBufferSize));
   stream->AddData(buffer, kBufferSize);
-  stream->Finalize();
+  stream->Finalize(0);

[tyoshino (SeeGerritForStatus), 2016/09/27 10:24:56]

check status() here

[jam, 2016/09/27 15:41:07]

Done.

   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(reader.completed());
   EXPECT_EQ(0, reader.buffer()->capacity());
 }
 
 TEST_F(StreamTest, GetStream) {
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   scoped_refptr<Stream> stream1(
@@ skipping 140 matching lines @@
 TEST_F(StreamTest, AbortPendingStream) {
   TestStreamWriter writer;
 
   GURL url("blob://stream");
   registry_->AbortPendingStream(url);
   scoped_refptr<Stream> stream1(new Stream(registry_.get(), &writer, url));
   ASSERT_EQ(nullptr, registry_->GetStream(url).get());
 }
 
 }  // namespace content