Issue 23689005: Widen GDI usage error suppression in skia.dll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23689005: Widen GDI usage error suppression in skia.dll. (Closed)

Created:
7 years, 3 months ago by Derek Bruening

Modified:
7 years, 3 months ago

Reviewers:
bungeman-chromium

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Widen GDI usage error suppression in skia.dll. TBR=bungeman@chromium.org BUG=266484 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220656

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Derek Bruening

Committed patchset #1 manually as r220656 (presubmit successful).

7 years, 3 months ago (2013-08-30 21:05:33 UTC) #2

bungeman-chromium

7 years, 3 months ago (2013-08-30 21:10:45 UTC) #3

Message was sent while issue was closed.

On 2013/08/30 21:05:33, Derek Bruening wrote:
> Committed patchset #1 manually as r220656 (presubmit successful).

LGTM

Note that, until we fix it, it may be possible for this to show up through other
code paths as well. The logically relevant part of the stack is

skia.dll!HDCOffscreen::draw
skia.dll!SkScalerContext_GDI::generateImage
skia.dll!SkScalerContext::getImage
skia.dll!SkGlyphCache::findImage

Narrower is better, of course, but this is logically the widest this should ever
get.

Expand Messages | Collapse Messages