Don't read past the end of the impulseResponse array

Source/core/platform/audio/ReverbConvolverStage.cpp

Index: Source/core/platform/audio/ReverbConvolverStage.cpp
diff --git a/Source/core/platform/audio/ReverbConvolverStage.cpp b/Source/core/platform/audio/ReverbConvolverStage.cpp
index e4c9954910c0639082bcbff51715c5b983d38f51..f59467afc67deb6459dff26524bf0e83dc034b5d 100644
--- a/Source/core/platform/audio/ReverbConvolverStage.cpp
+++ b/Source/core/platform/audio/ReverbConvolverStage.cpp
@@ -59,7 +59,7 @@ ReverbConvolverStage::ReverbConvolverStage(const float* impulseResponse, size_t,
         m_fftConvolver = adoptPtr(new FFTConvolver(fftSize));
     } else {
         m_directKernel = adoptPtr(new AudioFloatArray(fftSize / 2));
-        m_directKernel->copyToRange(impulseResponse + stageOffset, 0, fftSize / 2);
+        m_directKernel->copyToRange(impulseResponse + stageOffset, 0, std::min(stageLength, fftSize / 2));

[Ken Russell (switch to Gerrit), 2013/08/29 21:49:23]

Why does this guarantee that we won't read beyond the end of the impulseResponse
array?

The header says that the second argument to this constructor is called
"responseLength". However, this argument is *ignored* here in the
implementation. Why is the correct value then not (something like):

  std::min(std::max(0, responseLength - stageOffset), fftSize / 2)

Though taking into account that responseLength and stageOffset are both
unsigned?

         m_directConvolver = adoptPtr(new DirectConvolver(renderSliceSize));
     }
     m_temporaryBuffer.allocate(renderSliceSize);