Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2368883003: PlzNavigate: fix crash when updating redirect timing. (Closed)

Created:
4 years, 2 months ago by arthursonzogni
Modified:
4 years, 2 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, kinuko+watch, clamy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix crash when updating redirect timing. This CL prevents redirect timing to be set to zero when there is no redirection. BUG=576261 Committed: https://crrev.com/6a467a940e83c9d353ba1cb335be6f3ab96b2b2b Cr-Commit-Position: refs/heads/master@{#422732}

Patch Set 1 #

Patch Set 2 : Rebase + update filter. #

Total comments: 1

Patch Set 3 : Addressed Comment + rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.cpp View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (20 generated)
arthursonzogni
Hi Nate, This is the second part of the patch(2359723007) that has been broken in ...
4 years, 2 months ago (2016-09-26 08:42:54 UTC) #4
Nate Chapin
LGTM... https://codereview.chromium.org/2368883003/diff/20001/third_party/WebKit/Source/web/WebDataSourceImpl.cpp File third_party/WebKit/Source/web/WebDataSourceImpl.cpp (right): https://codereview.chromium.org/2368883003/diff/20001/third_party/WebKit/Source/web/WebDataSourceImpl.cpp#newcode80 third_party/WebKit/Source/web/WebDataSourceImpl.cpp:80: if (redirectChain.size() >= 2) { Please add a ...
4 years, 2 months ago (2016-09-30 23:03:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368883003/40001
4 years, 2 months ago (2016-10-04 07:51:13 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 07:56:41 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 07:58:43 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a467a940e83c9d353ba1cb335be6f3ab96b2b2b
Cr-Commit-Position: refs/heads/master@{#422732}

Powered by Google App Engine
This is Rietveld 408576698