Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23688006: Fix typo. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Fix typo. BUG=NONE TEST=NONE NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221745

Patch Set 1 #

Total comments: 2

Patch Set 2 : and another #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
achuithb
Please take a look, Tim.
7 years, 3 months ago (2013-09-06 18:51:06 UTC) #1
Tim Song
https://codereview.chromium.org/23688006/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/23688006/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode374 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:374: self.__WaitForSigninScreen() Extra underscore here.
7 years, 3 months ago (2013-09-06 18:59:45 UTC) #2
achuithb
https://codereview.chromium.org/23688006/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/23688006/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode374 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:374: self.__WaitForSigninScreen() On 2013/09/06 18:59:45, Tim Song wrote: > Extra ...
7 years, 3 months ago (2013-09-06 19:02:37 UTC) #3
Tim Song
lgtm
7 years, 3 months ago (2013-09-06 19:02:46 UTC) #4
achuithb
On 2013/09/06 19:02:46, Tim Song wrote: > lgtm ty!
7 years, 3 months ago (2013-09-06 19:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23688006/5001
7 years, 3 months ago (2013-09-06 19:05:48 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 19:06:54 UTC) #7
Message was sent while issue was closed. 
Change committed as 221745

Powered by Google App Engine
This is Rietveld 408576698