Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ppapi/proxy/url_loader_resource.cc

Issue 23688004: Change the PepperInProcessRouter to defer resource destruction messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/url_loader_resource.cc
diff --git a/ppapi/proxy/url_loader_resource.cc b/ppapi/proxy/url_loader_resource.cc
index 5bbc9372ff2dbea3af1b098d4a70a2673a93c211..8258959dc817a79774996d2d5e473b87bc8c8bfe 100644
--- a/ppapi/proxy/url_loader_resource.cc
+++ b/ppapi/proxy/url_loader_resource.cc
@@ -68,6 +68,12 @@ URLLoaderResource::URLLoaderResource(Connection connection,
}
URLLoaderResource::~URLLoaderResource() {
+ // Destroying a URLLoaderResource can cause the page to tear down the plugin
yzshen1 2013/09/06 22:07:47 I don't quite understand under what circumstances
+ // instance. For in-process plugins, this can happen before the base Resource
+ // class destructor runs, which removes this from the resource tracker. The
+ // instance tear down code will then attempt to call methods on this partially
+ // destructed object. Remove this from the tracker early to avoid this.
+ RemoveFromResourceTracker();
}
PPB_URLLoader_API* URLLoaderResource::AsPPB_URLLoader_API() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698