Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2368783002: Add tests for PaintPropertyTreePrinter, remove path printers (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, szager1, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for PaintPropertyTreePrinter, remove path printers This patch adds some basic testing of PaintPropertyTreePrinter which ensures trees can be print with and without root layer scrolling. Regular expressions have been used to focus on the tree structure and avoid dynamic output (e.g., pointer values). I am not aware of anyone using the path printers and have removed them to keep PaintPropertyTreePrinter lean & mean. BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8 Cr-Commit-Position: refs/heads/master@{#420964}

Patch Set 1 #

Patch Set 2 : Add debug guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -45 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 3 chunks +41 lines, -41 lines 0 comments Download
A third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 1 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
pdr.
4 years, 2 months ago (2016-09-26 16:22:54 UTC) #11
chrishtr
lgtm
4 years, 2 months ago (2016-09-26 17:41:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368783002/20001
4 years, 2 months ago (2016-09-26 17:42:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 19:41:04 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8 Cr-Commit-Position: refs/heads/master@{#420964}
4 years, 2 months ago (2016-09-26 19:42:39 UTC) #17
pdr.
4 years, 2 months ago (2016-09-27 05:05:09 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2372963002/ by pdr@chromium.org.

The reason for reverting is: This patch was correct but failed in combination
with https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7 and
https://crrev.com/0abd71cfec612222822a4e4a1bb0bc89e937a9ce which landed very
close to this patch. I'm going to roll this out instead of the other two to
green the tree faster. I'll re-land with the simple fix tomorrow..

Powered by Google App Engine
This is Rietveld 408576698