Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Issue 2368713002: cros: Small tweaks to palette behavior. (Closed)

Created:
4 years, 3 months ago by jdufault
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Small tweaks to palette behavior. Update laser icon color and automatically close the palette when enabling the magnifier or laser. BUG=645312 Committed: https://crrev.com/4424398217bc97ee9d29ab1c3aa8bce6a1549e16 Cr-Commit-Position: refs/heads/master@{#423642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/tools/magnifier_mode.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/resources/vector_icons/palette_tray_icon_laser_pointer.icon View 1 chunk +1 line, -1 line 0 comments Download
M ash/resources/vector_icons/palette_tray_icon_laser_pointer.1x.icon View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
jdufault
jamescook@ PTAL. Thanks!
4 years, 2 months ago (2016-10-05 18:48:12 UTC) #7
James Cook
LGTM but please update CL description to describe what the tweaks are. ;-)
4 years, 2 months ago (2016-10-05 19:43:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368713002/1
4 years, 2 months ago (2016-10-06 19:32:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:10:47 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:12:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4424398217bc97ee9d29ab1c3aa8bce6a1549e16
Cr-Commit-Position: refs/heads/master@{#423642}

Powered by Google App Engine
This is Rietveld 408576698